Skip to content

Commit 3aa86ac

Browse files
committed
Fix v2.BuildpacksTest for CAPI < 2.209.x
- The tests were too precise in checking the results. Now that the `lifecycle` property has been introduced in newer CAPI versions, the results are different between CAPI versions. - We now only check the basic information we care about in those tests (e.g. does the Buildpack exist given its name, or are the updated fields actually updated).
1 parent 7e0c3c7 commit 3aa86ac

File tree

1 file changed

+25
-68
lines changed

1 file changed

+25
-68
lines changed

integration-test/src/test/java/org/cloudfoundry/client/v2/BuildpacksTest.java

Lines changed: 25 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,11 @@ public void create() {
5858
.name(buildpackName)
5959
.position(2)
6060
.build())
61-
.map(ResourceUtils::getEntity)
61+
.thenMany(requestListBuildpacks(this.cloudFoundryClient, buildpackName))
62+
.map(BuildpackResource::getEntity)
63+
.map(BuildpackEntity::getName)
6264
.as(StepVerifier::create)
63-
.expectNext(
64-
BuildpackEntity.builder()
65-
.enabled(false)
66-
.locked(true)
67-
.name(buildpackName)
68-
.position(2)
69-
.lifecycle(LifecycleType.BUILDPACK)
70-
.build())
65+
.expectNext(buildpackName)
7166
.expectComplete()
7267
.verify(Duration.ofMinutes(5));
7368
}
@@ -130,15 +125,9 @@ public void get() {
130125
.buildpackId(buildpackId)
131126
.build()))
132127
.map(ResourceUtils::getEntity)
128+
.map(BuildpackEntity::getName)
133129
.as(StepVerifier::create)
134-
.expectNext(
135-
BuildpackEntity.builder()
136-
.enabled(false)
137-
.locked(false)
138-
.name(buildpackName)
139-
.position(3)
140-
.lifecycle(LifecycleType.BUILDPACK)
141-
.build())
130+
.expectNext(buildpackName)
142131
.expectComplete()
143132
.verify(Duration.ofMinutes(5));
144133
}
@@ -160,15 +149,9 @@ public void list() {
160149
.build()))
161150
.map(ResourceUtils::getEntity)
162151
.filter(entity -> buildpackName.equals(entity.getName())))
152+
.map(BuildpackEntity::getName)
163153
.as(StepVerifier::create)
164-
.expectNext(
165-
BuildpackEntity.builder()
166-
.enabled(false)
167-
.locked(false)
168-
.name(buildpackName)
169-
.position(3)
170-
.lifecycle(LifecycleType.BUILDPACK)
171-
.build())
154+
.expectNext(buildpackName)
172155
.expectComplete()
173156
.verify(Duration.ofMinutes(5));
174157
}
@@ -181,24 +164,19 @@ public void listFilterByName() {
181164
.flatMapMany(
182165
buildpackId ->
183166
PaginationUtils.requestClientV2Resources(
184-
page ->
185-
this.cloudFoundryClient
186-
.buildpacks()
187-
.list(
188-
ListBuildpacksRequest
189-
.builder()
190-
.name(buildpackName)
191-
.build()))
192-
.map(ResourceUtils::getEntity))
167+
page ->
168+
this.cloudFoundryClient
169+
.buildpacks()
170+
.list(
171+
ListBuildpacksRequest
172+
.builder()
173+
.name(buildpackName)
174+
.build()))
175+
)
176+
.map(ResourceUtils::getEntity)
177+
.map(BuildpackEntity::getName)
193178
.as(StepVerifier::create)
194-
.expectNext(
195-
BuildpackEntity.builder()
196-
.enabled(false)
197-
.locked(false)
198-
.name(buildpackName)
199-
.position(3)
200-
.lifecycle(LifecycleType.BUILDPACK)
201-
.build())
179+
.expectNext(buildpackName)
202180
.expectComplete()
203181
.verify(Duration.ofMinutes(5));
204182
}
@@ -221,14 +199,7 @@ public void update() {
221199
.build()))
222200
.map(ResourceUtils::getEntity)
223201
.as(StepVerifier::create)
224-
.expectNext(
225-
BuildpackEntity.builder()
226-
.enabled(true)
227-
.locked(true)
228-
.name(buildpackName)
229-
.position(2)
230-
.lifecycle(LifecycleType.BUILDPACK)
231-
.build())
202+
.expectNextMatches(b -> b.getEnabled() && b.getLocked() && b.getPosition().equals(2))
232203
.expectComplete()
233204
.verify(Duration.ofMinutes(5));
234205
}
@@ -251,16 +222,9 @@ public void upload() throws IOException {
251222
.filename(filename)
252223
.build()))
253224
.map(ResourceUtils::getEntity)
225+
.map(BuildpackEntity::getFilename)
254226
.as(StepVerifier::create)
255-
.expectNext(
256-
BuildpackEntity.builder()
257-
.enabled(false)
258-
.filename(filename)
259-
.locked(false)
260-
.name(buildpackName)
261-
.position(3)
262-
.lifecycle(LifecycleType.BUILDPACK)
263-
.build())
227+
.expectNext(filename)
264228
.expectComplete()
265229
.verify(Duration.ofMinutes(5));
266230
}
@@ -283,16 +247,9 @@ public void uploadDirectory() throws IOException {
283247
.filename(filename)
284248
.build()))
285249
.map(ResourceUtils::getEntity)
250+
.map(BuildpackEntity::getFilename)
286251
.as(StepVerifier::create)
287-
.expectNext(
288-
BuildpackEntity.builder()
289-
.enabled(false)
290-
.filename(filename + ".zip")
291-
.locked(false)
292-
.name(buildpackName)
293-
.position(3)
294-
.lifecycle(LifecycleType.BUILDPACK)
295-
.build())
252+
.expectNext(filename + ".zip")
296253
.expectComplete()
297254
.verify(Duration.ofMinutes(5));
298255
}

0 commit comments

Comments
 (0)