Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify overlapping event rules #19130

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

Clarify overlapping event rules #19130

wants to merge 1 commit into from

Conversation

harshil1712
Copy link
Contributor

Summary

Add notes to clarify overlapping event rules. Fixes #17949

@github-actions github-actions bot added the product:r2 R2 object storage: https://developers.cloudflare.com/r2 label Jan 10, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 283ffc3
Status: ✅  Deploy successful!
Preview URL: https://45856360.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://r2-event-notification-note.cloudflare-docs-7ou.pages.dev

View logs

@github-actions GitHub Actions
Copy link

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/r2/buckets/event-notifications/ https://r2-event-notification-note.cloudflare-docs-7ou.pages.dev/r2/buckets/event-notifications/

@bthwaites
Copy link
Contributor

This isn't quite accurate. You would be allowed to configure one rule with PutObject, prefix a/, and another with CopyObject, prefix a/. The key point is that we will reject any rule that overlaps with another rule such that multiple rules may trigger from the same R2 request. I'd suggest something like this:

  • Rule prefixes and suffixes for the same R2 action may not overlap in such a way that could cause multiple rules to trigger at once. For example, a rule with PutObject and prefix * and a rule with PutObject and prefix a/ would both match an object named a/b, and therefore may not be configured at the same time.

What do you think @jonesphillip ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oxyjun Oxyjun Awaiting requested review from Oxyjun Oxyjun is a code owner

@elithrar elithrar Awaiting requested review from elithrar elithrar is a code owner

@jonesphillip jonesphillip Awaiting requested review from jonesphillip jonesphillip is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@elithrar elithrar

@jonesphillip jonesphillip

@Oxyjun Oxyjun

Labels
product:r2 R2 object storage: https://developers.cloudflare.com/r2 size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation regarding conflicting event notification rules
5 participants
@harshil1712 @bthwaites @elithrar @jonesphillip @Oxyjun