Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Environment Var name is wrong #24

Open
BryceStevenWilley opened this issue May 15, 2022 · 0 comments
Open

API Environment Var name is wrong #24

BryceStevenWilley opened this issue May 15, 2022 · 0 comments

Comments

@BryceStevenWilley
Copy link
Contributor

Several places in the documentation mention that CLOUDCONVERT_API_KEY is the name of the environment variable to set in order to use the default_client(). However, environment_vars.py sets the name of the variable to be just "API_KEY", which is directly used in the default_client(). My guess is that environment_vars.py is supposed to just have the default values if the variables aren't present, but somehow was mistaken to have the names of those variables.

BryceStevenWilley added a commit to LemmaLegalConsulting/docassemble-tclpgoogledocsmerger that referenced this issue May 15, 2022
Handled several issues here:
1. The environment variables are wrongly hardcoded, and you can't
  use the alternative of providing your own API Keys from elsewhere.
  See cloudconvert/cloudconvert-python#13 and
  cloudconvert/cloudconvert-python#24. Will
  need to fix this to be able to run in docassemble.
2. Imports/uploading files: you need to follow this example: https://github.com/cloudconvert/cloudconvert-python#uploading-files
3. The output document somehow has more validation errors, but still opens fine in office.com.
  For some reason, the office converter doesn't convert from RTF to DOCX,
  so it uses the libreoffice converter instead, which generates all of those
  validation errors. Will just have to go with it, as long as some more obscure choices work
  in all of the testing files (drive, office 365, desktop office, and libreoffice).

  Details: combining from GDocs: 9 errors:
  * ExceptionError: Inner exception: 'a' is an undeclared prefix.
  * several Sch_AttributeValueDataTypeDetaileds, with in:w and in:hanging with invalid values (0.0 or 115.0 not valid Int16)

  from combining from cloudconvertAPI: 635 errors
  * mostly Sch_UnexpectedElementContentExpectingComplex: has unexpecetd child element 'main:b'
  * Sch_MissRequiredAttribute: the required attribute 'val' is missing
  * Sch_AttributeValueDataTypeDetailed: the attribute main:val has invalid value 'end' (sometimes 'start')

Resources to use when picking back up:
* https://sandbox.cloudconvert.com/dashboard/jobs#
* https://cloudconvert.com/api/v2/jobs/builder#
* https://cloudconvert.com/api/v2/import#import-url-tasks
BryceStevenWilley added a commit to LemmaLegalConsulting/cloudconvert-python that referenced this issue May 22, 2022
The actual env var being used was `API_KEY`. The documentation
mentions that the env var should be `CLOUDCONVERT_API_KEY` several times

Fixes cloudconvert#24.
BryceStevenWilley added a commit to LemmaLegalConsulting/docassemble-tclpgoogledocsmerger that referenced this issue May 30, 2022
Handled several issues here:
1. The environment variables are wrongly hardcoded, and you can't
  use the alternative of providing your own API Keys from elsewhere.
  See cloudconvert/cloudconvert-python#13 and
  cloudconvert/cloudconvert-python#24. Will
  need to fix this to be able to run in docassemble.
2. Imports/uploading files: you need to follow this example: https://github.com/cloudconvert/cloudconvert-python#uploading-files
3. The output document somehow has more validation errors, but still opens fine in office.com.
  For some reason, the office converter doesn't convert from RTF to DOCX,
  so it uses the libreoffice converter instead, which generates all of those
  validation errors. Will just have to go with it, as long as some more obscure choices work
  in all of the testing files (drive, office 365, desktop office, and libreoffice).

  Details: combining from GDocs: 9 errors:
  * ExceptionError: Inner exception: 'a' is an undeclared prefix.
  * several Sch_AttributeValueDataTypeDetaileds, with in:w and in:hanging with invalid values (0.0 or 115.0 not valid Int16)

  from combining from cloudconvertAPI: 635 errors
  * mostly Sch_UnexpectedElementContentExpectingComplex: has unexpecetd child element 'main:b'
  * Sch_MissRequiredAttribute: the required attribute 'val' is missing
  * Sch_AttributeValueDataTypeDetailed: the attribute main:val has invalid value 'end' (sometimes 'start')

Resources to use when picking back up:
* https://sandbox.cloudconvert.com/dashboard/jobs#
* https://cloudconvert.com/api/v2/jobs/builder#
* https://cloudconvert.com/api/v2/import#import-url-tasks
BryceStevenWilley added a commit to LemmaLegalConsulting/docassemble-tclpgoogledocsmerger that referenced this issue May 30, 2022
Handled several issues here:
1. The environment variables are wrongly hardcoded, and you can't
  use the alternative of providing your own API Keys from elsewhere.
  See cloudconvert/cloudconvert-python#13 and
  cloudconvert/cloudconvert-python#24. Will
  need to fix this to be able to run in docassemble.
2. Imports/uploading files: you need to follow this example: https://github.com/cloudconvert/cloudconvert-python#uploading-files
3. The output document somehow has more validation errors, but still opens fine in office.com.
  For some reason, the office converter doesn't convert from RTF to DOCX,
  so it uses the libreoffice converter instead, which generates all of those
  validation errors. Will just have to go with it, as long as some more obscure choices work
  in all of the testing files (drive, office 365, desktop office, and libreoffice).

  Details: combining from GDocs: 9 errors:
  * ExceptionError: Inner exception: 'a' is an undeclared prefix.
  * several Sch_AttributeValueDataTypeDetaileds, with in:w and in:hanging with invalid values (0.0 or 115.0 not valid Int16)

  from combining from cloudconvertAPI: 635 errors
  * mostly Sch_UnexpectedElementContentExpectingComplex: has unexpecetd child element 'main:b'
  * Sch_MissRequiredAttribute: the required attribute 'val' is missing
  * Sch_AttributeValueDataTypeDetailed: the attribute main:val has invalid value 'end' (sometimes 'start')

Resources to use when picking back up:
* https://sandbox.cloudconvert.com/dashboard/jobs#
* https://cloudconvert.com/api/v2/jobs/builder#
* https://cloudconvert.com/api/v2/import#import-url-tasks
BryceStevenWilley added a commit to LemmaLegalConsulting/docassemble-tclpgoogledocsmerger that referenced this issue May 31, 2022
Handled several issues here:
1. The environment variables are wrongly hardcoded, and you can't
  use the alternative of providing your own API Keys from elsewhere.
  See cloudconvert/cloudconvert-python#13 and
  cloudconvert/cloudconvert-python#24. Will
  need to fix this to be able to run in docassemble.
2. Imports/uploading files: you need to follow this example: https://github.com/cloudconvert/cloudconvert-python#uploading-files
3. The output document somehow has more validation errors, but still opens fine in office.com.
  For some reason, the office converter doesn't convert from RTF to DOCX,
  so it uses the libreoffice converter instead, which generates all of those
  validation errors. Will just have to go with it, as long as some more obscure choices work
  in all of the testing files (drive, office 365, desktop office, and libreoffice).

  Details: combining from GDocs: 9 errors:
  * ExceptionError: Inner exception: 'a' is an undeclared prefix.
  * several Sch_AttributeValueDataTypeDetaileds, with in:w and in:hanging with invalid values (0.0 or 115.0 not valid Int16)

  from combining from cloudconvertAPI: 635 errors
  * mostly Sch_UnexpectedElementContentExpectingComplex: has unexpecetd child element 'main:b'
  * Sch_MissRequiredAttribute: the required attribute 'val' is missing
  * Sch_AttributeValueDataTypeDetailed: the attribute main:val has invalid value 'end' (sometimes 'start')

Resources to use when picking back up:
* https://sandbox.cloudconvert.com/dashboard/jobs#
* https://cloudconvert.com/api/v2/jobs/builder#
* https://cloudconvert.com/api/v2/import#import-url-tasks
BryceStevenWilley added a commit to LemmaLegalConsulting/docassemble-tclpgoogledocsmerger that referenced this issue Jun 4, 2022
Handled several issues here:
1. The environment variables are wrongly hardcoded, and you can't
  use the alternative of providing your own API Keys from elsewhere.
  See cloudconvert/cloudconvert-python#13 and
  cloudconvert/cloudconvert-python#24. Will
  need to fix this to be able to run in docassemble.
2. Imports/uploading files: you need to follow this example: https://github.com/cloudconvert/cloudconvert-python#uploading-files
3. The output document somehow has more validation errors, but still opens fine in office.com.
  For some reason, the office converter doesn't convert from RTF to DOCX,
  so it uses the libreoffice converter instead, which generates all of those
  validation errors. Will just have to go with it, as long as some more obscure choices work
  in all of the testing files (drive, office 365, desktop office, and libreoffice).

  Details: combining from GDocs: 9 errors:
  * ExceptionError: Inner exception: 'a' is an undeclared prefix.
  * several Sch_AttributeValueDataTypeDetaileds, with in:w and in:hanging with invalid values (0.0 or 115.0 not valid Int16)

  from combining from cloudconvertAPI: 635 errors
  * mostly Sch_UnexpectedElementContentExpectingComplex: has unexpecetd child element 'main:b'
  * Sch_MissRequiredAttribute: the required attribute 'val' is missing
  * Sch_AttributeValueDataTypeDetailed: the attribute main:val has invalid value 'end' (sometimes 'start')

Resources to use when picking back up:
* https://sandbox.cloudconvert.com/dashboard/jobs#
* https://cloudconvert.com/api/v2/jobs/builder#
* https://cloudconvert.com/api/v2/import#import-url-tasks
BryceStevenWilley added a commit to LemmaLegalConsulting/docassemble-tclpgoogledocsmerger that referenced this issue Jun 22, 2022
* Start testing cloud convert API

Handled several issues here:
1. The environment variables are wrongly hardcoded, and you can't
  use the alternative of providing your own API Keys from elsewhere.
  See https://github.com / cloudconvert/cloudconvert-python/issues/13 and
  https://github.com / cloudconvert/cloudconvert-python/issues/24. Will
  need to fix this to be able to run in docassemble.
2. Imports/uploading files: you need to follow this example: https://github.com/cloudconvert/cloudconvert-python#uploading-files
3. The output document somehow has more validation errors, but still opens fine in office.com.
  For some reason, the office converter doesn't convert from RTF to DOCX,
  so it uses the libreoffice converter instead, which generates all of those
  validation errors. Will just have to go with it, as long as some more obscure choices work
  in all of the testing files (drive, office 365, desktop office, and libreoffice).

  Details: combining from GDocs: 9 errors:
  * ExceptionError: Inner exception: 'a' is an undeclared prefix.
  * several Sch_AttributeValueDataTypeDetaileds, with in:w and in:hanging with invalid values (0.0 or 115.0 not valid Int16)

  from combining from cloudconvertAPI: 635 errors
  * mostly Sch_UnexpectedElementContentExpectingComplex: has unexpected child element 'main:b'
  * Sch_MissRequiredAttribute: the required attribute 'val' is missing
  * Sch_AttributeValueDataTypeDetailed: the attribute main:val has invalid value 'end' (sometimes 'start')

Resources to use when picking back up:
* https://sandbox.cloudconvert.com/dashboard/jobs#
* https://cloudconvert.com/api/v2/jobs/builder#
* https://cloudconvert.com/api/v2/import#import-url-tasks

* Add cloudconvert API functions and hook into download

Adds a function that converts a DAFile docx to rtf and back and downloads it.
Also sets up the converter in the interview.

Depends on github-main clone of https://github.com/cloudconvert/cloudconvert-python,
(but not yet on pip) which lets you use
a non-default client.


* Added the cloud convert api key read in
* Ensure clauses are sorted alphabetically. Airtable stuff is no longer sorted alphabetically, so we can just sort both.
* made a param keyword only
* Cloudconvert prefix on function
* A standalone function should have been a method
* Make redis key consistent for all interviews

This is so the cache interview (not in commit) can fix things from the main
interview, mostly backwards compatible (gdoc caches now have a `gdocs_` prefix).

A side effect (desirable IMO) is that playground interviews will also control
and use the cache of the main, installed interview.

* Add the cache refresh interview

So normal people can go in and manually remove gdocs and airtable
caches. You shouldn't really have to remove the airtable cache, as
the whole thing refreshes every hour, but for gdocs you might want to
if you have to revert a document to an older (i.e. older gdocs modified
time) version of the document. We won't automatically use the currently
available one, just the last modified one.

* the documents themselves were being grabbed / downloaded multiple times
  due to the need for `template` and re-executing the merge code block. Fixed
  with a `need` attribute in the block
* Cloud convert throws errors if you don't have enough payments; catch those
  errors so we can still provide (a potentially bad) docx. TODO: Need to notify
  someone on those errors still.
* Removed April 7th mention in doc, since we've updated things manually much more recently than that, and will soon be updating automatically!
* bump version number to v0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant