Fix buggy special-display-buffer-names check (#3673)

The code in function cider-popup-display-buffer falsely assumes that each element of special-display-buffer-names is a list. In fact and as documented, each element can be either a string or a list (the car of which is a string).

CHANGELOG.md

@@ -35,6 +35,7 @@
 
 ### Bugs fixed
 
+- [#3673](https://github.com/clojure-emacs/cider/pull/3673): Fix buggy `special-display-buffer-names` check.
 - [#3659](https://github.com/clojure-emacs/cider/pull/3659): Fixes completions when using `flex`-like completion styles.
 - [#3600](https://github.com/clojure-emacs/cider/pull/3600): Fix scittle jack-in when using `cider-jack-in-clj`.
 - [#3663](https://github.com/clojure-emacs/cider/issues/3663): Fix `cider-interactive-eval-override` invocation.

cider-popup.el

@@ -64,7 +64,10 @@ by adding BUFFER-NAME to the `special-display-buffer-names' list."
     ;; another time through `cider-popup-buffer-display'):
     (if (and (boundp 'special-display-buffer-names)
              (seq-find (lambda (entry)
-                         (equal (car entry) buffer-name))
+                         ;; Fix issue #3672 Phil Hudson 2024-05-21
+                         ;; entry can be either a list or a string
+                         ;; Previous code falsely assumed entry is always a list
+                         (equal (if (listp entry) (car entry) entry) buffer-name))
                        special-display-buffer-names))
         (progn
           (display-buffer buffer-name)