Repository navigation
fix(bindings-typescript): reject failed procedure calls with InternalError (#6288) - #6349
Open
Tyagiquamar wants to merge 2 commits into
Open
Tyagiquamar wants to merge 2 commits into
Tyagiquamar wants to merge 2 commits into
Conversation
JasonAtClockwork
self-requested a review
November 10, 2026 17:22
Collaborator
|
A note from Zeke's AI agent: This repository requires verified commits. Please set up commit signing so GitHub marks your commits as Verified, then re-sign and re-push the unverified commits in this PR. Thank you! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A failed procedure call rejects with
InternalError, the same error type reducers already use.Root cause
Both procedure result handlers rejected with the raw
ProcedureResulterror string. Callers that catchInternalErrornever saw a procedure failure.Solution
Both handlers reject with
new InternalError(result.value).Rollback safety impact
n/a
Test plan
procedure internal error rejects with InternalErrorincrates/bindings-typescript/tests/db_connection.test.ts.Fixes #6288