Skip to content

Separate namespaces for pages and blobs in disk storage - #6599

Merged
kim merged 1 commit into
kim/tiered-storage-integrationfrom
kim/namespace-pages-blobs
Nov 16, 2026
Merged

kim merged 1 commit into
kim/tiered-storage-integrationfrom
kim/namespace-pages-blobs

Conversation

@kim

@kim kim commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

It is possible for a blob to have the same content hash as a page's
content_hash, the latter being different from hashing the actually
stored bytes.

To prevent these kinds of collisions, store pages and blobs separately.

API and ABI breaking changes

N/A

Rollback safety impact

N/A

Expected complexity level and risk

1

Testing

Existing

@kim
kim requested a review from joshua-spacetime November 16, 2026 15:34
@kim

kim commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Note: this PR is stacked to preserve my sanity. It doesn't depend on other patches in the stack, though, so can be landed separately.

@joshua-spacetime joshua-spacetime left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't prevent collisions in the snapshot itself right?

@kim

kim commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

No snapshots need to be addressed separately.
I couldn't think of a way to do it that would be rollback-safe, though.

It is possible for a blob to have the same content hash as a page's
`content_hash`, the latter being different from hashing the actually
stored bytes.

To prevent these kinds of collisions, store pages and blobs separately.
@kim
kim force-pushed the kim/namespace-pages-blobs branch from c318601 to 56f180f Compare November 16, 2026 18:59
@kim
kim changed the base branch from kim/reclamation-queue to kim/tiered-storage-integration November 16, 2026 18:59
@kim
kim merged commit 2f1d418 into kim/tiered-storage-integration Nov 16, 2026
8 of 12 checks passed
@kim
kim deleted the kim/namespace-pages-blobs branch November 16, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants