Repository navigation
Conversation
|
Our AI suggests that this PR covers several substantial changes that could be split into smaller PRs for easier review:
|
|
I have done some more testing. I will not do the change for Brotli quality as that is a lot depended on the schema/data which one is better at size and/or speed. So not a general good change to go for level 2. If we would look at decode speed that would change it. There it could make sense as with quality we could save the client 15% to 50% on decode time. So I'm going to check in the multi thread change if maybe moving to a different quality level is a good change when we can use multi lanes/threads in Brotli. But that will then come as a followup branch/pr to the multi thread compression. For the rest I will move them to there own PR's. |
|
Awesome, thank you for following up! |
Description of Changes
Improves WebSocket compression for small updates and large subscription responses:
zlib-rsgzip backend.Related to #6319’s compression-threshold concern and #5686’s Zstd request.
API and ABI breaking changes
Adds
Compression::Zstd, requiring updates to downstream exhaustive Rust matches. Zstd is explicitly requested; existing codecs, defaults, and message schemas remain compatible. Older servers reject the new option.Rollback safety impact
n/a — no persisted-format changes. Clients requesting Zstd must select an older codec when connecting to a rolled-back server.
Expected complexity level and risk
3/5. Changes compression scheduling, buffer ownership, and codec negotiation. Concurrent MT jobs can increase transient memory. MT remains disabled with core pinning; performance findings are synthetic, not production guarantees.
Testing