Repository navigation
Preserve declared enum variant names in TypeScript bindings - #6568
Open
rohanranjan0902 wants to merge 1 commit into
Open
rohanranjan0902 wants to merge 1 commit into
rohanranjan0902 wants to merge 1 commit into
Conversation
Contributor
|
@rohanranjan0902 This is a breaking change, so we couldn't ship this until at least 3.0. If we generate both names with a deprecation warning on the old version, then we could ship this. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #6562. TypeScript client code generation now preserves the declared names of sum-type variants instead of converting them to PascalCase. This keeps generated client tags consistent with the names used by TypeScript modules and the published schema.
Adds a regression test that checks generated bindings retain the variant names
owner,admin, andmember.API and ABI breaking changes
No wire-format or ABI change. Generated TypeScript enum variant names now match the schema’s declared names; clients that relied on the previous PascalCase names may need to update their code.
Expected complexity level and risk
The change is limited to TypeScript sum-type code generation. It affects generated enum names but does not change serialization, since sum variants are encoded by index.