Skip to content

Preserve declared enum variant names in TypeScript bindings - #6568

Open
rohanranjan0902 wants to merge 1 commit into
clockworklabs:masterfrom
rohanranjan0902:issue/6562-typescript-enum-variant-names
Open

rohanranjan0902 wants to merge 1 commit into
clockworklabs:masterfrom
rohanranjan0902:issue/6562-typescript-enum-variant-names

Conversation

@rohanranjan0902

Copy link
Copy Markdown
Contributor

Description of Changes

Fixes #6562. TypeScript client code generation now preserves the declared names of sum-type variants instead of converting them to PascalCase. This keeps generated client tags consistent with the names used by TypeScript modules and the published schema.

Adds a regression test that checks generated bindings retain the variant names owner, admin, and member.

API and ABI breaking changes

No wire-format or ABI change. Generated TypeScript enum variant names now match the schema’s declared names; clients that relied on the previous PascalCase names may need to update their code.

Expected complexity level and risk

The change is limited to TypeScript sum-type code generation. It affects generated enum names but does not change serialization, since sum variants are encoded by index.

@cloutiertyler

Copy link
Copy Markdown
Contributor

@rohanranjan0902 This is a breaking change, so we couldn't ship this until at least 3.0. If we generate both names with a deprecation warning on the old version, then we could ship this.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript client bindings rename enum variants to PascalCase, so module and client tags differ

2 participants