Skip to content

fix(bindings-typescript): reject failed procedure calls with InternalError (#6288) - #6349

Open
Tyagiquamar wants to merge 2 commits into
clockworklabs:masterfrom
Tyagiquamar:fix/ts-procedure-reject-internalerror-6288
Open

Tyagiquamar wants to merge 2 commits into
clockworklabs:masterfrom
Tyagiquamar:fix/ts-procedure-reject-internalerror-6288

Conversation

@Tyagiquamar

@Tyagiquamar Tyagiquamar commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

A failed procedure call rejects with InternalError, the same error type reducers already use.

Root cause

Both procedure result handlers rejected with the raw ProcedureResult error string. Callers that catch InternalError never saw a procedure failure.

Solution

Both handlers reject with new InternalError(result.value).

Rollback safety impact

n/a

Test plan

procedure internal error rejects with InternalError in crates/bindings-typescript/tests/db_connection.test.ts.

Fixes #6288

@JasonAtClockwork
JasonAtClockwork self-requested a review November 10, 2026 17:22
@bfops

bfops commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

A note from Zeke's AI agent: This repository requires verified commits. Please set up commit signing so GitHub marks your commits as Verified, then re-sign and re-push the unverified commits in this PR. Thank you!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TS SDK: failed procedure calls reject with a bare string instead of an Error

3 participants