Skip to content

Convert dev-dependencies to path dependencies #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
bfops opened this issue Apr 16, 2025 · 2 comments · Fixed by #2660
Closed
2 tasks done

Convert dev-dependencies to path dependencies #2620

bfops opened this issue Apr 16, 2025 · 2 comments · Fixed by #2660
Assignees
@bfops

Comments

@bfops
Copy link
Collaborator

bfops commented Apr 16, 2025 •
edited
Loading

cargo publish gets mad at "cyclic" dependencies due to dev-dependencies.

The github issue (rust-lang/cargo#4242) claims that if you use path dependencies, they will be automatically ignored.

Definition of "Done"

  • Update CI to complain about spacetimedb-* dev-dependencies that are not path dependencies
  • Convert all our spacetimedb-* dev-dependencies to be path dependencies
@bfops bfops self-assigned this Apr 16, 2025
@bfops
Copy link
Collaborator Author

bfops commented Apr 21, 2025

I think we should do this quickly if it is, in fact, tiny.

@bfops bfops linked a pull request Apr 22, 2025 that will close this issue
CI - Do some basic checks that crates are publishable #2660
Merged
2 tasks
@bfops
Copy link
Collaborator Author

bfops commented Apr 22, 2025

Took maybe ~45 minutes all told

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bfops bfops

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI - Do some basic checks that crates are publishable clockworklabs/SpacetimeDB
1 participant
@bfops