Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed different CSV column selection logic #11

Open
JensRantil opened this issue Mar 6, 2022 · 1 comment
Open

Proposed different CSV column selection logic #11

JensRantil opened this issue Mar 6, 2022 · 1 comment

Comments

@JensRantil
Copy link

JensRantil commented Mar 6, 2022

I have an interest in being able to parse additional transaction metadata from the CSV file, namely:

Currently the CSV parsing logic has few issues:

  • The actual columns used in the CSV files is not really well-documented; Neither README, nor website, states what goes in which column.
  • There is no logic to parse CSV columns in a different CSV file format than the assumed input. My bank allows me to download XLS files from them - it would be great if I simply could convert that Excel file into CSV and not have to transform the CSV file into a format that into-ledger can handle.
  • There is no logic to parse optional columns.

Proposal: I propose that

  • the -ic flag is removed.
  • every CSV-parseable transaction field gets an equivalent flag for which CSV column that field is stored in.
    • Required transaction fields (date, amount, description) default to >=0 index equivalent to today's functionality.
    • Optional fields (which I intend to add) default to field index <0. Enable by setting to a >=0 index.

What do you think about this? I'd be willing to submit a PR for this.

@JensRantil
Copy link
Author

Let me know if you'd like me to split this issue into two; One that deals with the new CSV field logic, and the second one about adding support for the additional transaction fields I want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant