Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js support revisited #58

Closed
euporos opened this issue Sep 4, 2020 · 2 comments
Closed

Node.js support revisited #58

euporos opened this issue Sep 4, 2020 · 2 comments

Comments

@euporos
Copy link

euporos commented Sep 4, 2020

Pull request #33 allegedly solved the compatibility issues with Node.js. The Readme, however, still states that Hickory “won't work out of the box on node”. I've been reading the heck out of anything related to the issue here, but haven't found any reproducible steps to make hickory load and parse on Node.js.

In case there is currently no sensible way to use hickory on Node.js, maybe there is a perspective to tap into posthtml-parser, a Node.js library that outputs something that is almost hickory format. I've elaborated on this solution to HTML-parsing on Node.js here (SO)

I'd be willing to attempt such an integration myself, but would want to make sure that there is indeed no proper solution as of this point (Also, this would be my very first pull request, so I'm a bit daunted and quite unsure if I could actually get it done).

@Stvad
Copy link

Stvad commented Jul 1, 2021

Hey @euporos I was wondering if you've ended up doing any work on this?

@slipset
Copy link
Member

slipset commented Nov 20, 2022

Closing this now as #33 is merged

@slipset slipset closed this as completed Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants