Skip to content

Commit df85e38

Browse files
committed
fix type issue with suggestion from code review
1 parent 876529c commit df85e38

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

apps/class-solid/src/components/Analysis.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export function TimeSeriesPlot() {
4949
const [xVariable, setXVariable] = createSignal("t");
5050
const [yVariable, setYVariable] = createSignal("theta");
5151
const xVariableOptions = ["t"]; // TODO: separate plot types for timeseries and x-vs-y? Use time axis?
52-
const yVariableOptions = BmiClass.get_output_var_names();
52+
const yVariableOptions = new BmiClass().get_output_var_names();
5353

5454
const chartData = createMemo(() => {
5555
return experiments

apps/class-solid/src/lib/runner.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export async function runClass(config: PartialConfig): Promise<ClassOutput> {
1515
const model = await new AsyncBmiClass();
1616
await model.initialize(parsedConfig);
1717
const output = await model.run({
18-
var_names: BmiClass.get_output_var_names(),
18+
var_names: new BmiClass().get_output_var_names(),
1919
});
2020
return output;
2121
} catch (error) {

packages/class/src/bmi.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export class BmiClass implements BmiLight<Config> {
6565
return ouput_var_names.length;
6666
}
6767

68-
static get_output_var_names() {
68+
get_output_var_names() {
6969
return ouput_var_names;
7070
}
7171

0 commit comments

Comments
 (0)