Fix df + remove sweep button (#125)

* Show coords in top left of plot (fixes #82)

* Added formatting to coord infobox

* Upload observations + wip try to render

but scales are not converting from domain to pixel, it stays domain

Refs #68

* Fix type error

* Display temp in kelvin so it renders on plot

* Theta and q now shown correctly on profile plot

* Also render sounding on skew-t plot and include in legend

* remove observationpoint dead code

* Include obs data in share URL

* typo

* Flatten death valley preset

* FOrmat

* Make df preset same runtime

* Remove sweep button

Fixes #78

---------

Co-authored-by: Peter Kalverla <peter.kalverla@gmx.com>

Author: sverhoeven

apps/class-solid/src/components/PermutationSweepButton.tsx

@@ -14,7 +14,6 @@ import {
   setPermutationConfigInExperiment,
   swapPermutationAndReferenceConfiguration,
 } from "~/lib/store";
-import { PermutationSweepButton } from "./PermutationSweepButton";
 import {
   MdiCakeVariantOutline,
   MdiCog,
@@ -303,10 +302,6 @@ export function PermutationsList(props: {
           experiment={props.experiment}
           experimentIndex={props.experimentIndex}
         />
-        <PermutationSweepButton
-          experiment={props.experiment}
-          experimentIndex={props.experimentIndex}
-        />
       </legend>
       <ul class="max-h-40 overflow-auto">
         <For each={props.experiment.config.permutations}>

apps/class-solid/src/components/PermutationsList.tsx

@@ -1,25 +1,19 @@
 {
   "name": "Death Valley",
   "description": "Preset with Death Valley conditions",
-  "initialState": {
-    "theta_0": 323,
-    "h_0": 200,
-    "dtheta_0": 1,
-    "q_0": 0.008,
-    "dq_0": -0.001
-  },
-  "timeControl": {
-    "dt": 60,
-    "runtime": 4320
-  },
-  "mixedLayer": {
-    "wtheta": 0.1,
-    "advtheta": 0,
-    "gammatheta": 0.006,
-    "wq": 0.0001,
-    "advq": 0,
-    "gammaq": 0,
-    "divU": 0,
-    "beta": 0.2
-  }
+  "theta_0": 323,
+  "h_0": 200,
+  "dtheta_0": 1,
+  "q_0": 0.008,
+  "dq_0": -0.001,
+  "dt": 60,
+  "runtime": 43200,
+  "wtheta": [0.1],
+  "advtheta": 0,
+  "gammatheta": 0.006,
+  "wq": 0.0001,
+  "advq": 0,
+  "gammaq": 0,
+  "divU": 0,
+  "beta": 0.2
 }

apps/class-solid/src/lib/presets/death-valley.json

@@ -44,35 +44,3 @@ test("Create share link from an experiment", async ({ page }) => {
 
   // TODO: finalheight is gone; implement alternative check to see that experiment finished
 });
-
-test("Given large app state, sharing is not possible", async ({ page }) => {
-  test.skip(
-    true,
-    "Plotting is too slow, to render 13 experiments with 24 permuations each",
-  );
-  await page.goto("/");
-
-  // Create a new experiment
-  await page.getByRole("button", { name: "Add Start from preset" }).click();
-  await page
-    .getByRole("button", { name: "Default The classic default" })
-    .click();
-  await page.getByRole("button", { name: "Run" }).click();
-  // Add permutation sweep
-  await page.getByRole("button", { name: "S", exact: true }).click();
-  await page.getByRole("button", { name: "Perform sweep" }).click();
-
-  // Duplicate the experiment 12 times
-  const times = 12;
-  for (let i = 0; i < times; i++) {
-    await page
-      .getByLabel("Default", { exact: true })
-      .getByRole("button", { name: "Duplicate experiment" })
-      .click();
-  }
-
-  await page.getByRole("button", { name: "Share" }).click();
-  await page.waitForSelector(
-    "text=Cannot share application state, it is too large. Please download each experiment by itself or make it smaller by removing permutations and/or experiments.",
-  );
-});

apps/class-solid/tests/share.spec.ts

@@ -47,12 +47,6 @@
         "default": "./dist/validate.js",
         "types": "./dist/validate.d.ts"
       }
-    },
-    "./sweep": {
-      "import": {
-        "default": "./dist/sweep.js",
-        "types": "./dist/sweep.d.ts"
-      }
     }
   },
   "homepage": "https://classmodel.github.io/class-web",