feat(udt): add udt info querying methods (fix #261 merge conflicts) #333
Conversation
🦋 Changeset detectedLatest commit: 2b3852b The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for apiccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @phroi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the UDT (User Defined Token) functionality by introducing a robust set of methods for querying UDT-related information and streamlining transaction completion processes. It provides developers with more granular control and clearer insights into UDT balances and cell management, while also improving error handling and documentation for a better development experience. The changes also resolve existing merge conflicts to facilitate smoother integration. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Deploy Preview for liveccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for appccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for docsccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces significant enhancements to the UDT (User Defined Token) handling by adding new methods for querying UDT information and improving transaction completion logic. The changes are well-structured, with new features like UdtInfo, calculateInfo, and a much more robust completeInputsByBalance method that handles both UDT balance and CKB capacity. The new test suite is comprehensive and covers many edge cases. The documentation for the new APIs is excellent. I've found one minor issue in the changeset configuration.
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| "@ckb-ccc/ssri": minor | |||
There was a problem hiding this comment.
This changeset includes a minor version bump for @ckb-ccc/ssri. However, based on the file changes in this pull request, there are no modifications to the ssri package. Bumping the version of an unchanged package could be misleading. Please consider removing this line if the version bump for @ckb-ccc/ssri is not intentional.
1 participant
Hey @Hanssen0, in this PR I fixed #261 minor merge conflicts: feel free to take the code in this branch and force push it on #261 as your own.
I tried to commit on #261, but I don't have the permissions.
Phroi %150