cilium: change comment to test clang-tidy workflow

Signed-off-by: Jarno Rajahalme <[email protected]>

Author: jrajahalme

cilium/network_policy.cc

@@ -75,8 +75,7 @@ IpAddressPair::IpAddressPair(const cilium::NetworkPolicy& proto) {
 
 class HeaderMatch : public Logger::Loggable<Logger::Id::config> {
 public:
-  HeaderMatch(const NetworkPolicyMap& parent, const cilium::HeaderMatch& config)
-      : name_(config.name()), value_(config.value()), match_action_(config.match_action()),
+  HeaderMatch(const NetworkPolicyMap& parent, const cilium::HeaderMatch& config) : name_(config.name()), value_(config.value()), match_action_(config.match_action()),
         mismatch_action_(config.mismatch_action()) {
     if (config.value_sds_secret().length() > 0) {
       secret_ = std::make_unique<SecretWatcher>(parent, config.value_sds_secret());
@@ -94,30 +93,30 @@ class HeaderMatch : public Logger::Loggable<Logger::Id::config> {
   // Returns 'true' if matching can continue
   bool allowed(Envoy::Http::RequestHeaderMap& headers, Cilium::AccessLog::Entry& log_entry) const {
     bool matches = false;
-    const std::string* match_value = &value_;
+    const std::string* matchValue = &value_;
     const auto header_value = Http::HeaderUtility::getAllOfHeaderAsString(headers, name_);
 
     // Get secret value?
     if (secret_) {
       auto* secret_value = secret_->value();
       if (secret_value) {
-        match_value = secret_value;
+        matchValue = secret_value;
       } else if (value_.length() == 0) {
-        // fail if secret has no value and the inline value to match is also empty
+        // Fail if secret has no value and the inline value to match is also empty.
         ENVOY_LOG(info, "Cilium HeaderMatch missing SDS secret value for header {}", name_);
         return false;
       }
     }
 
     // Perform presence match if the value to match is empty
-    bool is_present_match = match_value->length() == 0;
+    bool is_present_match = matchValue->length() == 0;
     if (is_present_match) {
       matches = header_value.result().has_value();
     } else if (header_value.result().has_value()) {
       const absl::string_view val = header_value.result().value();
-      if (val.length() == match_value->length()) {
+      if (val.length() == matchValue->length()) {
         // Use constant time comparison for security reason
-        matches = CRYPTO_memcmp(val.data(), match_value->data(), match_value->length()) == 0;
+        matches = CRYPTO_memcmp(val.data(), matchValue->data(), matchValue->length()) == 0;
       }
     }
 
@@ -128,10 +127,10 @@ class HeaderMatch : public Logger::Loggable<Logger::Id::config> {
         return true;
       case cilium::HeaderMatch::FAIL_ON_MATCH:
       default: // fail closed if unknown action
-        logRejected(log_entry, *match_value);
+        logRejected(log_entry, *matchValue);
         return false;
       case cilium::HeaderMatch::DELETE_ON_MATCH:
-        logRejected(log_entry, *match_value);
+        logRejected(log_entry, *matchValue);
         headers.remove(name_);
         return true;
       }
@@ -140,14 +139,14 @@ class HeaderMatch : public Logger::Loggable<Logger::Id::config> {
       switch (mismatch_action_) {
       case cilium::HeaderMatch::FAIL_ON_MISMATCH:
       default:
-        logMissing(log_entry, *match_value);
+        logMissing(log_entry, *matchValue);
         return false;
       case cilium::HeaderMatch::CONTINUE_ON_MISMATCH:
-        logMissing(log_entry, *match_value);
+        logMissing(log_entry, *matchValue);
         return true;
       case cilium::HeaderMatch::ADD_ON_MISMATCH:
-        headers.addCopy(name_, *match_value);
-        logMissing(log_entry, *match_value);
+        headers.addCopy(name_, *matchValue);
+        logMissing(log_entry, *matchValue);
         return true;
       case cilium::HeaderMatch::DELETE_ON_MISMATCH:
         if (is_present_match) {
@@ -168,9 +167,9 @@ class HeaderMatch : public Logger::Loggable<Logger::Id::config> {
           logRejected(log_entry, header_value.result().value());
         }
         // Set the expected value
-        headers.setCopy(name_, *match_value);
+        headers.setCopy(name_, *matchValue);
         // Log the expected value as missing
-        logMissing(log_entry, *match_value);
+        logMissing(log_entry, *matchValue);
         return true;
       }
     }