make the relation more consistent

Author: dominikzogg

phpstan.neon

@@ -9,9 +9,6 @@ parameters:
         -
             message: '#PHPDoc tag @var for variable \$entityRepository contains generic class Doctrine\\ORM\\EntityRepository but does not specify its types\: T#'
             path: %currentWorkingDirectory%/src/Repository/PetRepository.php
-        -
-            message: '#Property App\\Model\\Vaccination\:\:\$pet is never read, only written\.#'
-            path: %currentWorkingDirectory%/src/Model/Vaccination.php
         -
             message: '#Slim\\Interfaces\\RouteParserInterface\:\:urlFor\(\)#'
             path: %currentWorkingDirectory%/src/Parsing/PetParsing.php

src/Model/Pet.php

@@ -77,7 +77,11 @@ public function getTag(): ?string
      */
     public function setVaccinations(array $vaccinations): void
     {
-        $this->vaccinations->clear();
+        foreach ($this->vaccinations as $i => $vaccination) {
+            $vaccination->setPet(null);
+            $this->vaccinations->remove($i);
+        }
+
         foreach ($vaccinations as $vaccination) {
             $vaccination->setPet($this);
             $this->vaccinations->add($vaccination);

src/Model/Vaccination.php

@@ -39,6 +39,11 @@ public function setPet(?Pet $pet): void
         $this->pet = $pet;
     }
 
+    public function getPet(): ?Pet
+    {
+        return $this->pet;
+    }
+
     /**
      * @return array{name: null|string}
      */

tests/Unit/Model/PetTest.php

@@ -7,7 +7,6 @@
 use App\Model\ModelInterface;
 use App\Model\Pet;
 use App\Model\Vaccination;
-use App\Tests\Helper\AssertHelper;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -37,12 +36,24 @@ public function testGetSet(): void
         $vaccination2 = new Vaccination();
         $vaccination2->setName('Feline Acquired Immune Deficiency Syndrome');
 
+        $vaccination3 = new Vaccination();
+        $vaccination3->setName('Panleukopenia');
+
         $pet->setUpdatedAt($now);
         $pet->setName('Lucas');
         $pet->setTag('2018 OHIO DOG 87123 LUCAS');
-        $pet->setVaccinations([$vaccination2]);
+        $pet->setVaccinations([$vaccination2, $vaccination3]);
+
+        self::assertNull($vaccination1->getPet());
+        self::assertSame($pet, $vaccination2->getPet());
+        self::assertSame($pet, $vaccination3->getPet());
+
         $pet->setVaccinations([$vaccination1, $vaccination2]);
 
+        self::assertSame($pet, $vaccination1->getPet());
+        self::assertSame($pet, $vaccination2->getPet());
+        self::assertNull($vaccination3->getPet());
+
         self::assertSame($now, $pet->getUpdatedAt());
         self::assertSame('Lucas', $pet->getName());
         self::assertSame('2018 OHIO DOG 87123 LUCAS', $pet->getTag());
@@ -54,14 +65,11 @@ public function testGetSet(): void
         self::assertSame($vaccination1, array_shift($vaccinations));
         self::assertSame($vaccination2, array_shift($vaccinations));
 
-        self::assertSame('Rabies', AssertHelper::readProperty('name', $vaccination1));
-        self::assertSame($pet, AssertHelper::readProperty('pet', $vaccination1));
+        self::assertSame('Rabies', $vaccination1->getName());
+        self::assertSame($pet, $vaccination1->getPet());
 
-        self::assertSame(
-            'Feline Acquired Immune Deficiency Syndrome',
-            AssertHelper::readProperty('name', $vaccination2)
-        );
-        self::assertSame($pet, AssertHelper::readProperty('pet', $vaccination2));
+        self::assertSame('Feline Acquired Immune Deficiency Syndrome', $vaccination2->getName());
+        self::assertSame($pet, $vaccination2->getPet());
 
         self::assertSame([
             'id' => $pet->getId(),

tests/Unit/Model/VaccinationTest.php

@@ -6,7 +6,6 @@
 
 use App\Model\Pet;
 use App\Model\Vaccination;
-use App\Tests\Helper\AssertHelper;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -24,13 +23,14 @@ public function testGetSet(): void
 
         $pet = new Pet();
 
-        self::assertNull(AssertHelper::readProperty('pet', $vaccination));
+        self::assertNull($vaccination->getPet());
 
         $vaccination->setName('Rabies');
         $vaccination->setPet($pet);
 
         self::assertSame('Rabies', $vaccination->getName());
-        self::assertSame($pet, AssertHelper::readProperty('pet', $vaccination));
+
+        self::assertSame($pet, $vaccination->getPet());
 
         self::assertSame(['name' => $vaccination->getName()], $vaccination->jsonSerialize());
     }