Merge pull request #7 from crelies/dev

Chris · web-flow · commit 51ed9bf9b6cf · 2020-02-23T14:06:33.000+01:00
more unit tests, fixed xc test manifests
diff --git a/Tests/RemoteImageTests/Extensions/URLSession+RemoteImageURLDataPublisherTests.swift b/Tests/RemoteImageTests/Extensions/URLSession+RemoteImageURLDataPublisherTests.swift
@@ -21,4 +21,8 @@ final class URLSession_RemoteImageURLDataPublisherTests: XCTestCase {
         let dataPublisher = urlSession.dataPublisher(for: urlRequest)
         XCTAssertEqual(dataPublisher.description, dataTaskPublisher.description)
     }
+
+    static var allTests = [
+        ("testDataPublisher", testDataPublisher)
+    ]
 }
diff --git a/Tests/RemoteImageTests/Models/PhotoKitServiceErrorTests.swift b/Tests/RemoteImageTests/Models/PhotoKitServiceErrorTests.swift
@@ -61,4 +61,16 @@ final class PhotoKitServiceErrorTests: XCTestCase {
     func testErrorDomain() {
         XCTAssertEqual(PhotoKitServiceError.errorDomain, String(describing: PhotoKitService.self))
     }
+
+    static var allTests = [
+        ("testMissingDataErrorDescription", testMissingDataErrorDescription),
+        ("testMissingDataFailureReason", testMissingDataFailureReason),
+        ("testMissingDataRecoverySuggestion", testMissingDataRecoverySuggestion),
+        ("testMissingDataErrorCode", testMissingDataErrorCode),
+        ("testPhAssetNotFoundErrorDescription", testPhAssetNotFoundErrorDescription),
+        ("testPhAssetNotFoundFailureReason", testPhAssetNotFoundFailureReason),
+        ("testPhAssetNotFoundRecoverySuggestion", testPhAssetNotFoundRecoverySuggestion),
+        ("testPhAssetNotFoundErrorCode", testPhAssetNotFoundErrorCode),
+        ("testErrorDomain", testErrorDomain)
+    ]
 }
diff --git a/Tests/RemoteImageTests/Models/RemoteImageServiceErrorTests.swift b/Tests/RemoteImageTests/Models/RemoteImageServiceErrorTests.swift
@@ -14,4 +14,8 @@ final class RemoteImageServiceErrorTests: XCTestCase {
         let expectedDescription = "Could not create image from received data"
         XCTAssertEqual(description, expectedDescription)
     }
+
+    static var allTests = [
+        ("testCouldNotCreateImageDescription", testCouldNotCreateImageDescription)
+    ]
 }
diff --git a/Tests/RemoteImageTests/Models/RemoteImageStateTests.swift b/Tests/RemoteImageTests/Models/RemoteImageStateTests.swift
@@ -0,0 +1,43 @@
+//
+//  RemoteImageStateTests.swift
+//  RemoteImageTests
+//
+//  Created by Christian Elies on 23.02.20.
+//
+
+#if canImport(UIKit)
+@testable import RemoteImage
+import UIKit
+import XCTest
+
+final class RemoteImageStateTests: XCTestCase {
+    func testErrorValue() {
+        let error = NSError(domain: "MockDomain", code: 1, userInfo: nil)
+        let state: RemoteImageState = .error(error)
+        XCTAssertEqual(state.error, error)
+    }
+
+    func testNoErrorValue() {
+        let state: RemoteImageState = .loading
+        XCTAssertNil(state.error)
+    }
+
+    func testImageValue() {
+        let image = UIImage()
+        let state: RemoteImageState = .image(image)
+        XCTAssertEqual(state.image, image)
+    }
+
+    func testNoImageValue() {
+        let state: RemoteImageState = .loading
+        XCTAssertNil(state.image)
+    }
+
+    static var allTests = [
+        ("testErrorValue", testErrorValue),
+        ("testNoErrorValue", testNoErrorValue),
+        ("testImageValue", testImageValue),
+        ("testNoImageValue", testNoImageValue)
+    ]
+}
+#endif
diff --git a/Tests/RemoteImageTests/Services/PhotoKitServiceTests.swift b/Tests/RemoteImageTests/Services/PhotoKitServiceTests.swift
@@ -87,4 +87,10 @@ final class PhotoKitServiceTests: XCTestCase {
             XCTFail("Invalid photo data result")
         }
     }
+
+    static var allTests = [
+        ("testPhotoDataNotFound", testPhotoDataNotFound),
+        ("testPhotoDataFailure", testPhotoDataFailure),
+        ("testPhotoDataSuccess", testPhotoDataSuccess)
+    ]
 }
diff --git a/Tests/RemoteImageTests/Services/RemoteImageServiceDependenciesTests.swift b/Tests/RemoteImageTests/Services/RemoteImageServiceDependenciesTests.swift
@@ -15,4 +15,8 @@ final class RemoteImageServiceDependenciesTests: XCTestCase {
         XCTAssertTrue(dependencies.photoKitService is PhotoKitService)
         XCTAssertTrue(dependencies.remoteImageURLDataPublisher is URLSession)
     }
+
+    static var allTests = [
+        ("testInitialization", testInitialization)
+    ]
 }
diff --git a/Tests/RemoteImageTests/Services/RemoteImageServiceFactoryTests.swift b/Tests/RemoteImageTests/Services/RemoteImageServiceFactoryTests.swift
@@ -14,5 +14,9 @@ final class RemoteImageServiceFactoryTests: XCTestCase {
         let service = RemoteImageServiceFactory.makeRemoteImageService()
         XCTAssertEqual(service.state, .loading)
     }
+
+    static var allTests = [
+        ("testMakeRemoteImageService", testMakeRemoteImageService)
+    ]
 }
 #endif
diff --git a/Tests/RemoteImageTests/Services/RemoteImageServiceTests.swift b/Tests/RemoteImageTests/Services/RemoteImageServiceTests.swift
@@ -285,5 +285,16 @@ final class RemoteImageServiceTests: XCTestCase {
             XCTFail("Invalid fetch ph asset cached result")
         }
     }
+
+    static var allTests = [
+        ("testFetchImageURLSuccess", testFetchImageURLSuccess),
+        ("testFetchImageURLFailure", testFetchImageURLFailure),
+        ("testFetchImageURLFailureCompletion", testFetchImageURLFailureCompletion),
+        ("testFetchImageURLCached", testFetchImageURLCached),
+        ("testFetchPHAssetSuccess", testFetchPHAssetSuccess),
+        ("testFetchPHAccessInvalidData", testFetchPHAccessInvalidData),
+        ("testFetchPHAccessFailure", testFetchPHAccessFailure),
+        ("testFetchPHAssetCached", testFetchPHAssetCached)
+    ]
 }
 #endif
diff --git a/Tests/RemoteImageTests/Views/RemoteImageTests.swift b/Tests/RemoteImageTests/Views/RemoteImageTests.swift
@@ -34,5 +34,9 @@ final class RemoteImageTests: XCTestCase {
             XCTFail("\(error)")
         }
     }
+
+    static var allTests = [
+        ("testLoadingState", testLoadingState)
+    ]
 }
 #endif
diff --git a/Tests/RemoteImageTests/XCTestManifests.swift b/Tests/RemoteImageTests/XCTestManifests.swift
@@ -3,7 +3,16 @@ import XCTest
 #if !canImport(ObjectiveC)
 public func allTests() -> [XCTestCaseEntry] {
     return [
-        testCase(DefaultRemoteImageCacheTests.allTests)
+        testCase(DefaultRemoteImageCacheTests.allTests),
+        testCase(PhotoKitServiceErrorTests.allTests),
+        testCase(PhotoKitServiceTests.allTests),
+        testCase(RemoteImageTests.allTests),
+        testCase(RemoteImageServiceDependenciesTests.allTests),
+        testCase(RemoteImageServiceErrorTests.allTests),
+        testCase(RemoteImageServiceFactoryTests.allTests),
+        testCase(RemoteImageServiceTests.allTests),
+        testCase(RemoteImageStateTests.allTests),
+        testCase(URLSession_RemoteImageURLDataPublisherTests.allTests)
     ]
 }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -21,4 +21,8 @@ final class URLSession_RemoteImageURLDataPublisherTests: XCTestCase {`
`21`	`21`	`let dataPublisher = urlSession.dataPublisher(for: urlRequest)`
`22`	`22`	`XCTAssertEqual(dataPublisher.description, dataTaskPublisher.description)`
`23`	`23`	`}`
	`24`	`+`
	`25`	`+ static var allTests = [`
	`26`	`+ ("testDataPublisher", testDataPublisher)`
	`27`	`+ ]`
`24`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,4 +14,8 @@ final class RemoteImageServiceErrorTests: XCTestCase {`
`14`	`14`	`let expectedDescription = "Could not create image from received data"`
`15`	`15`	`XCTAssertEqual(description, expectedDescription)`
`16`	`16`	`}`
	`17`	`+`
	`18`	`+ static var allTests = [`
	`19`	`+ ("testCouldNotCreateImageDescription", testCouldNotCreateImageDescription)`
	`20`	`+ ]`
`17`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -87,4 +87,10 @@ final class PhotoKitServiceTests: XCTestCase {`
`87`	`87`	`XCTFail("Invalid photo data result")`
`88`	`88`	`}`
`89`	`89`	`}`
	`90`	`+`
	`91`	`+ static var allTests = [`
	`92`	`+ ("testPhotoDataNotFound", testPhotoDataNotFound),`
	`93`	`+ ("testPhotoDataFailure", testPhotoDataFailure),`
	`94`	`+ ("testPhotoDataSuccess", testPhotoDataSuccess)`
	`95`	`+ ]`
`90`	`96`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,4 +15,8 @@ final class RemoteImageServiceDependenciesTests: XCTestCase {`
`15`	`15`	`XCTAssertTrue(dependencies.photoKitService is PhotoKitService)`
`16`	`16`	`XCTAssertTrue(dependencies.remoteImageURLDataPublisher is URLSession)`
`17`	`17`	`}`
	`18`	`+`
	`19`	`+ static var allTests = [`
	`20`	`+ ("testInitialization", testInitialization)`
	`21`	`+ ]`
`18`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,5 +14,9 @@ final class RemoteImageServiceFactoryTests: XCTestCase {`
`14`	`14`	`let service = RemoteImageServiceFactory.makeRemoteImageService()`
`15`	`15`	`XCTAssertEqual(service.state, .loading)`
`16`	`16`	`}`
	`17`	`+`
	`18`	`+ static var allTests = [`
	`19`	`+ ("testMakeRemoteImageService", testMakeRemoteImageService)`
	`20`	`+ ]`
`17`	`21`	`}`
`18`	`22`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -285,5 +285,16 @@ final class RemoteImageServiceTests: XCTestCase {`
`285`	`285`	`XCTFail("Invalid fetch ph asset cached result")`
`286`	`286`	`}`
`287`	`287`	`}`
	`288`	`+`
	`289`	`+ static var allTests = [`
	`290`	`+ ("testFetchImageURLSuccess", testFetchImageURLSuccess),`
	`291`	`+ ("testFetchImageURLFailure", testFetchImageURLFailure),`
	`292`	`+ ("testFetchImageURLFailureCompletion", testFetchImageURLFailureCompletion),`
	`293`	`+ ("testFetchImageURLCached", testFetchImageURLCached),`
	`294`	`+ ("testFetchPHAssetSuccess", testFetchPHAssetSuccess),`
	`295`	`+ ("testFetchPHAccessInvalidData", testFetchPHAccessInvalidData),`
	`296`	`+ ("testFetchPHAccessFailure", testFetchPHAccessFailure),`
	`297`	`+ ("testFetchPHAssetCached", testFetchPHAssetCached)`
	`298`	`+ ]`
`288`	`299`	`}`
`289`	`300`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -34,5 +34,9 @@ final class RemoteImageTests: XCTestCase {`
`34`	`34`	`XCTFail("\(error)")`
`35`	`35`	`}`
`36`	`36`	`}`
	`37`	`+`
	`38`	`+ static var allTests = [`
	`39`	`+ ("testLoadingState", testLoadingState)`
	`40`	`+ ]`
`37`	`41`	`}`
`38`	`42`	`#endif`