-
Notifications
You must be signed in to change notification settings - Fork 195
Windows Server 2016 testing environment #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
a0cb281
8da4e45
e210db3
3f1957b
bf79b5a
281121f
23a36bd
43f1d60
c58ea8e
54853a0
096d6b2
bc94963
0f9575b
4dfb617
e09c0e8
f77c489
5f155c6
bdc0f01
20267af
5e176a2
43c0b71
77829d5
240b251
144e857
c52d79f
cb40707
c9c4bf5
ea71c9f
ccf6946
c59ea97
ab109c0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ end | |
| Vagrant.configure("2") do |config| | ||
| # This setting will download the atlas box at | ||
| # https://atlas.hashicorp.com/ferventcoder/boxes/win2012r2-x64-nocm | ||
| config.vm.box = "ferventcoder/win2012r2-x64-nocm" | ||
| config.vm.box = "BasicTheProgram/windows_2016" | ||
|
|
||
| # http://docs.vagrantup.com/v2/providers/configuration.html | ||
| # http://docs.vagrantup.com/v2/virtualbox/configuration.html | ||
|
|
@@ -29,7 +29,7 @@ Vagrant.configure("2") do |config| | |
| v.customize ["modifyvm", :id, "--vram", 32] | ||
| # For better DNS resolution | ||
| v.customize ["modifyvm", :id, "--natdnshostresolver1", "on"] | ||
| # No audo | ||
| # No audio | ||
basictheprogram marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| v.customize ["modifyvm", :id, "--audio", "none"] | ||
| # Clipboard enabled | ||
| v.customize ["modifyvm", :id, "--clipboard", "bidirectional"] | ||
|
|
@@ -84,6 +84,7 @@ Vagrant.configure("2") do |config| | |
| # naming of this directory being `vagrant` is just a coincedence). | ||
| # Share `packages` directory as `C:\packages` | ||
| config.vm.synced_folder "packages", "/packages" | ||
|
|
||
| #config.vm.synced_folder "temp", "/Users/vagrant/AppData/Local/Temp/chocolatey" | ||
| # not recommended for sharing, it may have issues with `vagrant sandbox rollback` | ||
| #config.vm.synced_folder "chocolatey", "/ProgramData/chocolatey" | ||
|
|
@@ -107,10 +108,11 @@ Vagrant.configure("2") do |config| | |
| config.vm.provision :shell, :path => "shell/InstallChocolatey.ps1" | ||
| config.vm.provision :shell, :path => "shell/NotifyGuiAppsOfEnvironmentChanges.ps1" | ||
| else | ||
| config.vm.provision :shell, :path => "shell/PrepareWindows.ps1", :powershell_elevated_interactive => true | ||
| config.vm.provision :shell, :path => "shell/InstallNet4.ps1", :powershell_elevated_interactive => true | ||
| config.vm.provision :shell, :path => "shell/InstallChocolatey.ps1", :powershell_elevated_interactive => true | ||
| config.vm.provision :shell, :path => "shell/NotifyGuiAppsOfEnvironmentChanges.ps1", :powershell_elevated_interactive => true | ||
| config.vm.provision :shell, :path => "shell/PrepareWindows.ps1", privileged: false | ||
| config.vm.provision :shell, :path => "shell/InstallNet4.ps1", privileged: false | ||
| config.vm.provision :shell, :path => "shell/InstallChocolatey.ps1", privileged: false | ||
| config.vm.provision :shell, :path => "shell/NotifyGuiAppsOfEnvironmentChanges.ps1",privileged: false | ||
| config.vm.provision :shell, :path => "shell/InstallToolchain.ps1", privileged: false | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why non-privileged? It needs to succeed, which is highly likely to need to run with admin on the VM. Not sure I understand this change
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See hashicorp/vagrant#9138 for the ugly details. Looks like a change in Windows Server 2016 Build 14393.rs1_release.170917-1700. Happy to change it if you know another work-around for Windows Server 2016. If you read the ticket the upstream maintainer of the packer scripts reports that this specific build of Windows Server 2016 has the problem. So can work around it or wait(?) for Microsoft to change thing back? |
||
| end | ||
|
|
||
| $packageTestScript = <<SCRIPT | ||
|
|
@@ -140,6 +142,6 @@ SCRIPT | |
| if Vagrant::VERSION < '1.8.0' | ||
| config.vm.provision :shell, :inline => $packageTestScript | ||
| else | ||
| config.vm.provision :shell, :inline => $packageTestScript, :powershell_elevated_interactive => true | ||
| config.vm.provision :shell, :inline => $packageTestScript, privileged: false | ||
| end | ||
| end | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| if (Get-Command "choco.exe" -ErrorAction SilentlyContinue) | ||
| { | ||
| "7zip", "bitvise-ssh-server", "git", "notepadplusplus" | ForEach-Object -Process {choco install $_} | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need for these to be here. They were pre-installed on the older system
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See https://github.com/chocolatey/chocolatey-test-environment/issues the tool chain is very old and I'd like to have the tools upgraded. We can fork the packer project and add the tools in packer but this keeps the design clean and installs current tools in this project. See my comments about using chocolatey to install the tools because I view the test environment as testing chocolatey packages and not chocolatey itself it's ok(?) to use chocolate to install the latest version of tools?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
That's likely fine. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure we'd convert to another box, apologies. We would need to really review it for safety and security, as this test environment is used in many environments.
And do you have vmware_fusion, hyper-v, and virtualbox versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have fusion, or hyper-v versions, but packer has the ability to build all of the above with a pretty simple command line evocation.
See my comments in the google group about having git branches for each version of windows or having multiple versions of Windows supported in the VagrantFile.
I have the need for a Windows 2016 testing environment, thus these changes. I don't want to deprecated or diminish the Server 2012 R2 stuff, ideally supporting multiple test environments is the goal. Just need guidance from you on how to do that.
And, ideally, you'd take over the official config.vm.box stuff. Probably build via packer to make it easier for people to contribute to the test environment?