From 20ab37a22b227744051545e90115568ce827e7cf Mon Sep 17 00:00:00 2001
From: Debove Christopher <chibiblasphem@gmail.com>
Date: Tue, 28 Jan 2025 15:25:00 +0100
Subject: [PATCH] fix: minor visual bugs (#672)
* fix: remove whitespace-pre on real-time if no live version
* fix: empty rule table broken
---
.../routes/_builder+/scenarios+/$scenarioId+/home.tsx | 9 +++++++--
.../$scenarioId+/i+/$iterationId+/_edit-view+/rules.tsx | 3 ++-
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/packages/app-builder/src/routes/_builder+/scenarios+/$scenarioId+/home.tsx b/packages/app-builder/src/routes/_builder+/scenarios+/$scenarioId+/home.tsx
index 1911b50d9..94c98e1aa 100644
--- a/packages/app-builder/src/routes/_builder+/scenarios+/$scenarioId+/home.tsx
+++ b/packages/app-builder/src/routes/_builder+/scenarios+/$scenarioId+/home.tsx
@@ -456,14 +456,19 @@ function RealTimeSection({
}}
/>
</span>
- <span className="text-grey-00 text-s inline-flex items-center whitespace-pre font-semibold">
+ <span
+ className={clsx(
+ 'text-grey-00 text-s inline-flex items-center font-semibold',
+ { 'whitespace-pre': isLive },
+ )}
+ >
{isLive ? (
<Trans
t={t}
i18nKey="scenarios:home.execution.real_time.callout.scenario_id"
components={{
CopyScenarioId: (
- <CopyToClipboardButton toCopy={scenarioId}>
+ <CopyToClipboardButton toCopy={scenarioId} className="ml-1">
<code>scenario_id</code>
</CopyToClipboardButton>
),
diff --git a/packages/app-builder/src/routes/_builder+/scenarios+/$scenarioId+/i+/$iterationId+/_edit-view+/rules.tsx b/packages/app-builder/src/routes/_builder+/scenarios+/$scenarioId+/i+/$iterationId+/_edit-view+/rules.tsx
index b8c8ce4c9..f51eb785b 100644
--- a/packages/app-builder/src/routes/_builder+/scenarios+/$scenarioId+/i+/$iterationId+/_edit-view+/rules.tsx
+++ b/packages/app-builder/src/routes/_builder+/scenarios+/$scenarioId+/i+/$iterationId+/_edit-view+/rules.tsx
@@ -206,6 +206,7 @@ export default function Rules() {
getSortedRowModel: getSortedRowModel(),
rowLink: ({ id }) => <Link to={`./${fromUUID(id)}`} />,
});
+ const columnLength = table.getHeaderGroups()[0]?.headers.length ?? 1;
return (
<div className="flex flex-col gap-4">
@@ -252,7 +253,7 @@ export default function Rules() {
rows.map((row) => <Table.Row key={row.id} row={row} />)
) : (
<tr className="h-28">
- <td colSpan={columns.length}>
+ <td colSpan={columnLength}>
<p className="text-center">{t('scenarios:rules.empty')}</p>
</td>
</tr>