Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JSON data types? #14

Open
nathanrboyer opened this issue Feb 6, 2025 · 2 comments
Open

Change JSON data types? #14

nathanrboyer opened this issue Feb 6, 2025 · 2 comments

Comments

@nathanrboyer
Copy link
Contributor

nathanrboyer commented Feb 6, 2025

For my personal project (that I can share once it's a little more polished), I'd prefer the following changes to the data structure:

  1. health to be listed as an integer or null (as was done in V2) rather than a string or empty string
  2. pack to be listed as an array of pack names rather than using "Every" (even in the single-pack case)

Both of these are something I can probably deal with on my side, but I thought I would bring it up in case you think these changes might be useful in general. My PRs so far were just find/replace, so I would rely on you to implement these more involved changes if you like them. But also feel free to just close and ignore this if you prefer it the current way. Thanks for your effort to collect this data!

@chase-manning
Copy link
Owner

Thanks @nathanrboyer . These are both good changes. Agree they are nicer than the current. Please feel free to raise a PR to change to this format. Otherwise I can do this for you but won't have time until probably next week as traveling at the moment.

@nathanrboyer
Copy link
Contributor Author

No rush, thanks! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants