You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For my personal project (that I can share once it's a little more polished), I'd prefer the following changes to the data structure:
health to be listed as an integer or null (as was done in V2) rather than a string or empty string
pack to be listed as an array of pack names rather than using "Every" (even in the single-pack case)
Both of these are something I can probably deal with on my side, but I thought I would bring it up in case you think these changes might be useful in general. My PRs so far were just find/replace, so I would rely on you to implement these more involved changes if you like them. But also feel free to just close and ignore this if you prefer it the current way. Thanks for your effort to collect this data!
The text was updated successfully, but these errors were encountered:
Thanks @nathanrboyer . These are both good changes. Agree they are nicer than the current. Please feel free to raise a PR to change to this format. Otherwise I can do this for you but won't have time until probably next week as traveling at the moment.
For my personal project (that I can share once it's a little more polished), I'd prefer the following changes to the data structure:
health
to be listed as an integer ornull
(as was done in V2) rather than a string or empty stringpack
to be listed as an array of pack names rather than using"Every"
(even in the single-pack case)Both of these are something I can probably deal with on my side, but I thought I would bring it up in case you think these changes might be useful in general. My PRs so far were just find/replace, so I would rely on you to implement these more involved changes if you like them. But also feel free to just close and ignore this if you prefer it the current way. Thanks for your effort to collect this data!
The text was updated successfully, but these errors were encountered: