From a54c58aa0aba50fa12e320f443995f8dc7c7959c Mon Sep 17 00:00:00 2001 From: Alex Coleman <77301670+alex-statsig@users.noreply.github.com> Date: Sat, 14 Dec 2024 15:08:21 -0800 Subject: [PATCH] Remove unnecessary chart updates on drags --- src/handlers.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/handlers.ts b/src/handlers.ts index 6405fa5e..c443bfc9 100644 --- a/src/handlers.ts +++ b/src/handlers.ts @@ -45,7 +45,7 @@ export function mouseMove(chart: Chart, event: MouseEvent) { if (state.dragStart) { state.dragging = true state.dragEnd = event - chart.update('none') + chart.draw(); } } @@ -58,7 +58,7 @@ function keyDown(chart: Chart, event: KeyboardEvent) { removeHandler(chart, 'keydown') state.dragging = false state.dragStart = state.dragEnd = undefined - chart.update('none') + chart.draw(); } function getPointPosition(event: MouseEvent, chart: Chart) { @@ -203,12 +203,12 @@ export function mouseUp(chart: Chart, event: MouseEvent) { const distanceY = directionEnabled(mode, 'y', chart) ? rect.height : 0 const distance = Math.sqrt(distanceX * distanceX + distanceY * distanceY) - // Remove drag start and end before chart update to stop drawing selected area + // Remove drag start and end before chart render to stop drawing selected area state.dragStart = state.dragEnd = undefined if (distance <= threshold) { state.dragging = false - chart.update('none') + chart.draw(); return }