fix: rethink global config path on windows: use $HOME/.config
#1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We made a mistake when it comes to the global config path on Windows. On macOS and Linux we use two different paths for data and config: `XDG_DATA_HOME` and `XDG_CONFIG_HOME`. On Windows though, we were using the same path for both data and config: `LOCALAPPDATA`. This caused confusion and means the user has no separate dir to store config separate of data. In theory we could consider something as `APPDATA`, but honestly, I propose that we just use `$HOME/.config`. It's easier to find and consistent with how other tools work. Git and other terminal tools also use `$HOME/.config`, so users are used to it. This is not a breaking change because the old path will still load, so existing setting will load as expected. Fixes #1347
andreynering
requested review from
kujtimiihoxha
and removed request for
a team
kujtimiihoxha
approved these changes
Nov 3, 2025
andreynering
deleted the
charm-808-the-global-configuration-file-path-and-ephemeral-data-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made a mistake when it comes to the global config path on Windows. On macOS and Linux we use two different paths for data and config:
XDG_DATA_HOMEandXDG_CONFIG_HOME. On Windows though, we were using the same path for both data and config:LOCALAPPDATA. This caused confusion and means the user has no separate dir to store config separate of data.In theory we could consider something as
APPDATA, but honestly, I propose that we just use$HOME/.config. It's easier to find and consistent with how other tools work. Git and other terminal tools also use$HOME/.config, so users are used to it.This is not a breaking change because the old path will still load, so existing setting will load as expected.