Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rebuild] mcpelauncher-ui-git mcpelauncher-linux-git #2660

Closed
REmerald opened this issue Jul 19, 2023 · 15 comments
Closed

[Rebuild] mcpelauncher-ui-git mcpelauncher-linux-git #2660

REmerald opened this issue Jul 19, 2023 · 15 comments
Labels
priority:medium This package affects less than a hundred users. request:rebuild-pkg Package is missing a rebuild.

Comments

@REmerald
Copy link

Packages:

mcpelauncher-ui-git
mcpelauncher-linux-git

Latest chaotic version

v0.9.0.qt6.r1.ge52a436-1 v0.9.0.qt6.r8.g27eb1b8-1

Reason for rebuild

Broken, requires .so file with non-existing suffix.

Rebuilding should fix the issue. See minecraft-linux/mcpelauncher-ui-manifest#57.

Logs

https://builds.garudalinux.org/repos/chaotic-aur/logs/mcpelauncher-ui-git.log
https://builds.garudalinux.org/repos/chaotic-aur/logs/mcpelauncher-linux-git.log

Builds?

Didn't try building myself.

More information

┐(゚~゚)┌

@REmerald REmerald added the request:rebuild-pkg Package is missing a rebuild. label Jul 19, 2023
@dr460nf1r3 dr460nf1r3 added the priority:medium This package affects less than a hundred users. label Jul 22, 2023
@dr460nf1r3
Copy link
Member

Looks like there are a lot of issues when attempting the rebuild (logs).
mcpelauncher-linux-git additionally probably needs to be updated? (fatal: invalid reference: origin/qt6)

@ChristopherHX
Copy link

ChristopherHX commented Jul 23, 2023

How to reproduce fatal: invalid reference: origin/qt6? mcpelauncher-linux-git builds fine: log https://github.com/minecraft-linux/appimage-builder/actions/runs/5585114956/job/15264748018#step:5:1

protobuf deliberaly enforces c++17(c++14) to a c++11 codebase for the ui as of now and will cause hundred of errors.

Looks like there are a lot of issues when attempting the rebuild (logs).

resolved by telling the cmake to use c++17 due to protobuf upgrade.

@REmerald
Copy link
Author

REmerald commented Jul 25, 2023

@Technetium1, @dr460nf1r3, @xiota, both -ui-git and -linux-git have built fine in the clean chroot:
mcpelauncher-ui-git.log
(forgot to dump the log of -linux-git before making it, and my terminal crashed after I tried to paste its history to vim, 😞)

Also, -ui-git disappeared from the repo, for some reason...

Btw, maybe it'll be a good idea to add mcpelauncher-appimage (it's usually older but more stable, and can be used when the git version is broken)?

@Technetium1
Copy link
Member

One of the primary issues right now seems to be getting qt6-webengine:

 qt6-webengine-6.5.2-1-x86_64 downloading...
checking keyring...
checking package integrity...
error: qt6-webengine: signature from "Antonio Rojas <[email protected]>" is invalid
:: File /var/cache/pacman/pkg/qt6-webengine-6.5.2-1-x86_64.pkg.tar.zst is corrupted (invalid or corrupted package (PGP signature)).
Do you want to delete it? [Y/n] error: failed to commit transaction (invalid or corrupted package)

@REmerald
Copy link
Author

REmerald commented Aug 8, 2023

@Technetium1, is that a bug of the arch extra repo? Or the archlinux-keyring package?

@Technetium1
Copy link
Member

I believe it was with the keyring. It's solved now.

@REmerald
Copy link
Author

@Technetium1 @dr460nf1r3, protobuf updated recently [2023-09-21T01:49:52+0300] [ALPM] upgraded protobuf (24.2-1 -> 24.2-2), so binary mcpelauncher-ui-qt broke again

mcpelauncher-ui-qt: symbol lookup error: mcpelauncher-ui-qt: undefined symbol: _ZN6google8protobuf8internal17AssignDescriptorsEPFPKNS1_15DescriptorTableEvEPN4absl12lts_202301259once_flagERKNS0_8MetadataE

So, I think rebuilding mcpelauncher-ui-git (and mcpelauncher-linux-git just in case) should fix it.

@Technetium1
Copy link
Member

@dr460nf1r3 I was going to do it but lower is missing again (?!?)

@Technetium1 Technetium1 reopened this Sep 21, 2023
@dr460nf1r3
Copy link
Member

Hum, thats weird! It can be regenerated with chaotic lw btw.

Is

mcpelauncher-ui-git v0.11.0.qt6.r3.ga40ddb0-1

the broken version or did it update in the meantime?

@REmerald
Copy link
Author

@dr460nf1r3, ga40ddb0 commit is from the qt6 branch, if I understood your question correctly.

@dr460nf1r3
Copy link
Member

Well, what I meant is the following: if I understood it correctly, mcpelauncher-ui-git currently fails to open due to protobuf updates. Therefore my question was whether the broken package you are using has the mentioned version. In any case, I rebuilt both packages. Since those are -git packages you might need to reinstall the package in order to profit from it (which might also produce a signature error, just retry and it'll work).

@REmerald
Copy link
Author

whether the broken package you are using has the mentioned version

Yes, it has, and it worked before protobuf upgrade

In any case, I rebuilt both packages.

Thanks, this fixed the issue, the launcher launches now.

Since those are -git packages you might need to reinstall the package in order to profit from it

Hmm, theoretically, could we increment the last digit in the package, next time it happens? E.g. v0.11.0.qt6.r3.ga40ddb0-2, so that pacman would see it as an update?
It would help the people, not knowing about the issue, as well.

which might also produce a signature error, just retry and it'll work

Yep, it did. Thanks for telling.

Anyways, everything works now, thanks a lot.

@dr460nf1r3
Copy link
Member

Hmm, theoretically, could we increment the last digit in the package, next time it happens? E.g. v0.11.0.qt6.r3.ga40ddb0-2, so that pacman would see it as an update?
It would help the people, not knowing about the issue, as well.

We already do this for non vcs packages. It does work by increasing pkgrel by 0.1 though, which doesn't apply to vcs packages however as they set their pkgver based on pkgver() of the PKGBUILD itself.

@xiota
Copy link
Contributor

xiota commented Sep 22, 2023

We already do this for non vcs packages. It does work by increasing pkgrel by 0.1 though, which doesn't apply to vcs packages however as they set their pkgver based on pkgver() of the PKGBUILD itself.

@dr460nf1r3 I noticed bumping works with -git packages that were recently updated and don't have any upstream commits yet. So this suggestion for toolbox could fix bumps... chaotic-aur/toolbox#92

We already do this for non vcs packages.

I'll run a search for affected -git packages to rebuild later.

@dr460nf1r3
Copy link
Member

Yes, I thought about that too while writing the post @xiota

@xiota xiota closed this as completed Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium This package affects less than a hundred users. request:rebuild-pkg Package is missing a rebuild.
Development

No branches or pull requests

5 participants