Skip to content

Augur DB CLI: create schema should use check_call and fail if there is an error. #3579

@MoralCode

Description

@MoralCode
  1. Silent failure in augur/application/cli/db.py:
def create_schema():
    call(["alembic", "upgrade", "head"])  # uses call(), not check_call()

subprocess.call() returns the exit code but doesn't raise on failure - so the script happily continues even when Alembic fails.

Originally posted by @shlokgilda in #3451

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions