Rework apk cache into coalescing caches #1769
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusthoemmes
force-pushed
the
cache-transport-rework
branch
from
7ef2196 to
224ea71
Compare
There's nothing inherently wrong with the existing implementation other than that I found it to be unnecessarily complex to read. This reworks it into a generic `coalescingCache`, which seems to be applicable to the etags cache as-is as well.
markusthoemmes
force-pushed
the
cache-transport-rework
branch
from
224ea71 to
04acab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's nothing inherently wrong with the existing implementation other than that I found it to be unnecessarily complex to read. This reworks it into a generic
coalescingCache, which seems to be applicable to the etags cache as-is as well.