You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
args.gpu and concat_mols are not consistent with other codes and will throw errors. They should be modified to device and converter, since they are extracted from args or defined in previous lines like this:
I noticed in example code, some argument are inconsistent in the commented parts, such as lines in
examples/molnet/train_molnet.py
:chainer-chemistry/examples/molnet/train_molnet.py
Lines 267 to 274 in 56e83de
args.gpu
andconcat_mols
are not consistent with other codes and will throw errors. They should be modified todevice
andconverter
, since they are extracted fromargs
or defined in previous lines like this:chainer-chemistry/examples/molnet/train_molnet.py
Line 209 in 56e83de
chainer-chemistry/examples/molnet/train_molnet.py
Line 233 in 56e83de
Since this mistake is too minor to PR, a small issue is enough. Have a nice day :-)
The text was updated successfully, but these errors were encountered: