New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weight tying option has a bug #399

Open

knshnb opened this issue Sep 20, 2019 · 1 comment

Contributor

knshnb commented Sep 20, 2019

If weight_tying option is True, only one update layer is called regardless of n_update_layers

https://github.com/pfnet-research/chainer-chemistry/blob/master/chainer_chemistry/models/gin.py#L37

The text was updated successfully, but these errors were encountered:

knshnb mentioned this issue

Chainer graph #398

Merged

Member

corochann commented Sep 20, 2019

So we should change this line to self.n_update_layers ?
https://github.com/pfnet-research/chainer-chemistry/blob/master/chainer_chemistry/models/gin.py#L92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment