Skip to content

Feedback on handling FS errors #5

@coreyfarrell

Description

@coreyfarrell

No handling is currently in place for any FS errors - either the file is successfully read or assumed to not exist.

Should any errors result in exceptions being thrown:

  • Permission errors on FS
  • Request for directory which does not exist
  • Request for file which does not exist
  • package.json exists but cannot be parsed

What should happen if /path/to/package.json denies read permissions but /path/to/file.js can be read? This edge case could result in the wrong decision, we should match whatever node.js would do. Should we assume commonjs upon access denied reading /path/to/package.json or should we attempt to look at /path/package.json?

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions