Skip to content

Commit a6701c2

Browse files
author
Ross Penman
committed
Don't cache resource classes based on model class
resource_for_model passes the model instance, so resources can vary based on model instance. Therefore, caching based on the model class can cause incorrect resources to be used.
1 parent 8f1a7c3 commit a6701c2

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

lib/jsonapi/resource.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -743,9 +743,8 @@ def find(filters, options = {})
743743
end
744744

745745
def resources_for(records, context)
746-
resource_classes = {}
747746
records.collect do |model|
748-
resource_class = resource_classes[model.class] ||= self.resource_for_model(model)
747+
resource_class = self.resource_for_model(model)
749748
resource_class.new(model, context)
750749
end
751750
end

0 commit comments

Comments
 (0)