Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-salt status/apply sanity check: all minion nodes should have clean "zypper ps -s" #341

Open
smithfarm opened this issue Aug 25, 2020 · 5 comments
Assignees
Labels
low-hanging-fruit Simple tasks to get started

Comments

@smithfarm
Copy link
Contributor

If "zypper ps -s" is not clean on all nodes, ceph-salt apply should not initiate the Salt Formula.

@smithfarm smithfarm self-assigned this Sep 4, 2020
@LenzGr
Copy link
Contributor

LenzGr commented Sep 9, 2020

Sadly, the Salt Zypper module does not seem to support this natively, so this would have to be implemented differently.

@smithfarm
Copy link
Contributor Author

Sadly, the Salt Zypper module does not seem to support this natively, so this would have to be implemented differently.

Right. This will be implemented by running zypper ps and grepping the output for the string "No processes using deleted files found". (We are already using this in ceph-salt reboot and ceph-salt update --reboot to determine whether nodes need to be rebooted.)

@ricardoasmarques ricardoasmarques added the low-hanging-fruit Simple tasks to get started label Sep 23, 2020
@sebastian-philipp
Copy link
Contributor

Working around issues of the Salt Zypper module seems strange to me.

@smithfarm
Copy link
Contributor Author

Working around issues of the Salt Zypper module seems strange to me.

Sounds like you haven't had the honor of working with this module before :-)

@sebastian-philipp
Copy link
Contributor

Working around issues of the Salt Zypper module seems strange to me.

Sounds like you haven't had the honor of working with this module before :-)

haha, not yet 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-hanging-fruit Simple tasks to get started
Projects
None yet
Development

No branches or pull requests

4 participants