Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoupling pool-system from pool-registry tests #1771

Open
lemunozm opened this issue Mar 15, 2024 · 0 comments
Open

Decoupling pool-system from pool-registry tests #1771

lemunozm opened this issue Mar 15, 2024 · 0 comments
Labels
I11-cleaning No mandatory issue that leave the repo more readable/organized P2-nice-to-have Issue is worth doing. Q3-medium Can be done with good experience in the language, but little knowledge of the codebase.

Comments

@lemunozm
Copy link
Contributor

Description

pallet-pool-registry is quite simple on its own. Nevertheless, the mock and benchmarks use a lot of knowledge comming from pool-system, breaking pool-registry each time pool-system changes.

We should test only the internal behavior of pool-registry in this pallet, avoiding configuring pools and pool dependencies.
@lemunozm lemunozm added Q3-medium Can be done with good experience in the language, but little knowledge of the codebase. P2-nice-to-have Issue is worth doing. I11-cleaning No mandatory issue that leave the repo more readable/organized labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I11-cleaning No mandatory issue that leave the repo more readable/organized P2-nice-to-have Issue is worth doing. Q3-medium Can be done with good experience in the language, but little knowledge of the codebase.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lemunozm