Skip to content
This repository has been archived by the owner on Mar 8, 2021. It is now read-only.

redirect-new-auth redirects to http instead of https when behind a proxy #131

Open
timothypratley opened this issue Dec 1, 2014 · 3 comments

Comments

@timothypratley
Copy link
Contributor

Fortunately I am able to avoid this behavior by setting the flag to be false in the auth meta-data...

It seems unnecessary to use the entire context:
(str (:context request) (-> request ::auth-config :default-landing-uri ))

@cemerick
Copy link
Owner

Do you mean redirect-new-auth? redirect-on-auth is an optional metadata key on credential maps.

@timothypratley
Copy link
Contributor Author

yes 😃

@timothypratley timothypratley changed the title redirect-on-auth redirects to http instead of https when behind a proxy redirect-new-auth redirects to http instead of https when behind a proxy Mar 13, 2015
@cemerick
Copy link
Owner

OK, I see what you mean. I think the context is required insofar as the :default-landing-uri is going to be (or should be?) defined in terms of it.

In any case, I guess we should apply all the same measures used in requires-scheme-with-proxy to translate the resulting URL to use the appropriate scheme, etc. PR welcome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants