Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add feegrant curl guide #1892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hexmarkd
Copy link
Contributor

@hexmarkd hexmarkd commented Feb 11, 2025

Added documentation for using feegrant with curl commands in the feegrant-for-blobs.md guide.

Closes #1779

Summary by CodeRabbit

  • Documentation
    • Introduced new guidance detailing how to use fee allowances with curl commands.
    • Provided a step-by-step process including instructions for authentication and feegrant requests.
    • Updated command examples and responses for improved clarity and consistency.
    • Made formatting tweaks to enhance readability in code blocks.

Copy link
Contributor

coderabbitai bot commented Feb 11, 2025

Walkthrough

The documentation has been expanded by adding a new section titled “Optional: Using FeeGrant with curl commands” to guide users through granting fee allowances using curl. The update includes step-by-step instructions for starting a local light node, exporting an authentication token, retrieving the granter address, setting the grantee address, and issuing a feegrant request via curl. Minor formatting adjustments and reformatting of command examples have been applied for consistency.

Changes

File Changes Summary
how-to-guides/feegrant-for-blobs.md Added “Optional: Using FeeGrant with curl commands” section; updated formatting and command examples

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LightNode
    participant API
    User->>LightNode: Start local light node
    User->>LightNode: Export auth token and retrieve granter address
    User->>User: Set grantee address
    User->>API: Send feegrant request via curl
    API-->>User: Return feegrant response
Loading

Assessment against linked issues

Objective Addressed Explanation
docs: feegrant with curl [#1779]

Possibly related PRs

  • docs: update feegrant UX #1683: Enhances FeeGrant documentation with improved command syntax and user instructions, closely aligning with the changes in this PR.

Suggested reviewers

  • vgonkivs
  • jcstein

Poem

I hop and nibble through the code,
Adding guides on the Exchange Road.
FeeGrant with curl shines so bright,
Helping users with each command in sight.
With joyful hops, my changes take flight! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
how-to-guides/feegrant-for-blobs.md (3)

241-262: Add explanation for gas parameters.

The curl command includes hardcoded values for gas_price (0.002) and gas (142225). Consider:

  1. Explaining how these values were determined
  2. Providing guidance on adjusting them based on network conditions
       \"params\": [
         \"$GRANTEE_ADDRESS\",
         \"42\",
         {
-          \"gas_price\": 0.002,
+          \"gas_price\": 0.002,  # Minimum gas price for Mocha testnet
           \"is_gas_price_set\": true,
-          \"gas\": 142225,
+          \"gas\": 142225,  # Estimated gas limit for feegrant transactions

Also consider adding a note about checking current network conditions for appropriate gas values.


264-277: Add error handling guidance.

The guide shows a successful response but doesn't cover potential error scenarios. Consider adding:

  1. Common error responses
  2. Troubleshooting steps
  3. How to handle timeouts or network issues

279-279: Fix formatting issues.

  1. Line 279 exceeds the line length limit. Consider breaking the URL into a separate line.
  2. Line 283 has inconsistent punctuation. Add a period at the end for consistency.
-You can verify the transaction on [Celenium Explorer](https://mocha.celenium.io/tx/4AAFDA4CE622C56CE9681B7E3BE7773E3B36ABE6C02BD66111BD2F2491011FD2?tab=messages) by searching for the transaction hash.
+You can verify the transaction on [Celenium Explorer] by searching for the transaction hash.
+
+[Celenium Explorer]: https://mocha.celenium.io/tx/4AAFDA4CE622C56CE9681B7E3BE7773E3B36ABE6C02BD66111BD2F2491011FD2?tab=messages

-The parameters in the request are:
+The parameters in the request are as follows:

Also applies to: 283-283

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

279-279: Line length
Expected: 80; Actual: 200

(MD013, line-length)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5c748c and a21eca5.

📒 Files selected for processing (1)
  • how-to-guides/feegrant-for-blobs.md (6 hunks)
🧰 Additional context used
🪛 LanguageTool
how-to-guides/feegrant-for-blobs.md

[uncategorized] ~283-~283: Loose punctuation mark.
Context: ...eters in the request are: - gas_price: The price of gas in utia - `is_gas_pric...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 markdownlint-cli2 (0.17.2)
how-to-guides/feegrant-for-blobs.md

279-279: Line length
Expected: 80; Actual: 200

(MD013, line-length)

🔇 Additional comments (2)
how-to-guides/feegrant-for-blobs.md (2)

108-108: LGTM! Formatting improvements.

The added markdownlint comments and JSON response formatting changes improve code readability and maintainability.

Also applies to: 118-126, 149-156, 175-190


208-212: LGTM! Well-structured curl guide.

The new section provides clear and comprehensive instructions for using FeeGrant with curl commands, which aligns well with the PR objectives of enhancing the feegrant documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: feegrant with curl
1 participant