Skip to content

Commit e73dc05

Browse files
Merge pull request #11 from cedadev/devel
Fix to ndg.httpsclient.utils.open_url utility function
2 parents 0ee675b + e5e36bc commit e73dc05

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ of the SSL peer using ``pyasn1``.
88

99
Releases
1010
========
11+
0.4.2
12+
-----
13+
* Fix to bug in ``ndg.httpsclient.utils.open_url`` - duplicate open call.
14+
Nb. This bug and the fix DO NOT affect the ``httplib``and ``urllib2``
15+
interfaces that this package provides.
16+
1117
0.4.1
1218
-----
1319
* Added explicit ref to Python 3 in classifier text for Python 3 checking tools.

ndg/httpsclient/utils.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,9 +217,6 @@ def open_url(url, config, data=None, handlers=None):
217217
return_message = ''
218218
response = None
219219

220-
# FIXME
221-
response = opener.open(request)
222-
223220
try:
224221
response = opener.open(request)
225222
return_message = response.msg

setup.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@
1818
1919
Releases
2020
========
21+
0.4.2
22+
-----
23+
* Fix to bug in ``ndg.httpsclient.utils.open_url`` - duplicate open call.
24+
Nb. This bug and the fix DO NOT affect the ``httplib``and ``urllib2``
25+
interfaces that this package provides.
26+
2127
0.4.1
2228
-----
2329
* Added explicit ref to Python 3 in classifier text for Python 3 checking tools.
@@ -112,7 +118,7 @@
112118

113119
setup(
114120
name='ndg_httpsclient',
115-
version="0.4.1",
121+
version="0.4.2",
116122
description='Provides enhanced HTTPS support for httplib and urllib2 using '
117123
'PyOpenSSL',
118124
author='Richard Wilkinson and Philip Kershaw',

0 commit comments

Comments
 (0)