👷⬆️ update MQT workflows to v1.6 #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added
continuous integration
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
=====================================
Coverage 92.2% 92.2%
=====================================
Files 126 126
Lines 13830 13830
Branches 2153 2153
=====================================
Hits 12761 12761
Misses 1069 1069
|
burgholzer
added
extensive-cpp-ci
This was referenced Jan 21, 2025
burgholzer
added a commit
that referenced
this pull request
Jan 21, 2025
## Description This fixes a small bug observed as part of #803, which only surfaced on Windows in Debug mode when compiling using Clang 🤯 Part of the block collection code in the circuit optimizer would invalidate an iterator due to an update of the respective container being iterated over within the loop. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. Signed-off-by: Lukas Burgholzer <[email protected]>
burgholzer
added
the
extensive-python-ci
burgholzer
force-pushed
the
try-extensive-ci
branch
from
2f7ee6d to
02af1b7
Compare
burgholzer
added a commit
that referenced
this pull request
Jan 22, 2025
…y check (#809) ## Description This PR fixes another small bug observed as part of #803, which only surfaced under macOS when using GCC as the compiler. Turns out that GitHub's CodeQL was right after all and exact equality checks on floating point values can come back to bite you. In this case, two computations of `std::tan(1.0)` resulted in values that were off by a single ULP. Although I am not 100% certain how this can even happen, this PR works around any such errors by using a fuzzy floating point comparison with an epsilon on the order of `10-12`. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines.
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
this avoids running it twice when running extensive Python CI Signed-off-by: burgholzer <[email protected]>
burgholzer
force-pushed
the
try-extensive-ci
branch
from
cedf7d7 to
f61e7ff
Compare
Signed-off-by: burgholzer <[email protected]>
Turns out these uploads hardly provided any value and just consumed CI runtime. At least we now know that this is possible and how to achieve it, if we ever need it again. Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adopts the latest version of the MQT workflows, which contains the changes from munich-quantum-toolkit/workflows#60.
By default, C++ CI is now only run in Release mode for all major platforms. However, when a PR is tagged with
extensive-cpp-ci, a large set of test runs will be started on various operating system versions using various compilers.Similarly, adding a
extensive-python-cilabel will trigger additional Python test runs on different OS versions.Note that the labels need to be present before CI starts running, or the already started/completed CI may need to be rerun.
Most small PRs should be fine to run with the default set of runs. The extensive CI should be enabled for infrastructure-critical PRs or, more generally, at the end of the PR cycle before merging.
In addition, this update brings support for natively building
aarch64wheels using GitHub's new Ubuntu ARM runners, which are now enabled by default.Finally, this PR drops the TestPyPI uploads given their little value over the last couple of months and their substantial runner demand.
Checklist: