Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--chugin-probe incorrectly says chugin is OK #358

Open
nshaheed opened this issue Sep 4, 2023 · 0 comments
Open

--chugin-probe incorrectly says chugin is OK #358

nshaheed opened this issue Sep 4, 2023 · 0 comments

Comments

@nshaheed
Copy link
Contributor

nshaheed commented Sep 4, 2023

There's a discrepancy between the new chugin error reporting and --chugin-probe:

If I improperly define a chugin, I now get these nice new error messages:

[chuck:2:SYSTEM]:  | loading chugins...
[chuck:3:HERALD]:  | searching 'C:\Users\nick/Documents/ChucK/chugins'
[chuck:2:SYSTEM]:  |  | (error) imported class 'Hydra' extends 'UGen'...
[chuck:2:SYSTEM]:  |  |  |- but does not contain UGen functions (e.g., tick)
[chuck:2:SYSTEM]:  |  |  |- (hint: chugin missing QUERY->add_ugen_func()?)
[chuck:2:SYSTEM]:  |  |  |- (origin: C:\Users\nick/Documents/ChucK/chugins/Hydra.chug)
[chuck:3:HERALD]:  |  | [FAILED] loading chugin Hydra.chug (8.1)
[chuck:3:HERALD]:  |  |  | reason: unsuccessful query in dll 'C:\Users\nick/Documents/ChucK'
[chuck:3:HERALD]:  |  |  | skipping 'C:\Users\nick/Documents/ChucK/chugins/Hydra.chug'...

However, if I do chuck --chugin-probe, everything seems hunky-dory:

[chuck:2:SYSTEM]: probing chugins in search paths...
[chuck:2:SYSTEM]:  | searching 'C:\Users\nick/Documents/ChucK/chugins'
[chuck:2:SYSTEM]:  |  | [OK] chugin Hydra.chug (8.1)

I guess the probe is only validating the api versions, not actually trying to load the chugins? This may be out of scope for probe itself, but I think the probe text should be more clear about what it's probing exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant