Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make main scripts work in concert #11

Closed
phette23 opened this issue Sep 6, 2023 · 0 comments
Closed

make main scripts work in concert #11

phette23 opened this issue Sep 6, 2023 · 0 comments
Assignees
@phette23

Comments

@phette23
Copy link
Member

phette23 commented Sep 6, 2023 •
edited
Loading

We should be able to feed the missing patrons JSON file created by the patch_prox_num script into create_koha_csv as that's the natural next step. Right now, you have to rename the missing patrons file (e.g. to employee_data.json) and also edit it so there's a top-level Report_Entry key pointing to the array of people. The first step is easy but the second is annoying.
phette23 added a commit that referenced this issue Dec 21, 2023
@phette23
make create_koha_csv work with array JSON
c799c5a 
now works with either Workday-style {"Report_Entry": []} JSON
or a straight array e.g. from the patch prox script
ref #11
@phette23 phette23 self-assigned this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phette23 phette23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phette23