Skip to content

Commit eb1a92f

Browse files
authored
Merge pull request #17 from cbusillo/fix/publish-workflow
Fix publish workflow
2 parents c91a21a + 48de3e7 commit eb1a92f

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

.github/workflows/publish.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,10 @@ jobs:
9696

9797
- name: Publish to TestPyPI
9898
if: inputs.repository == 'testpypi'
99-
uses: pypa/gh-action-pypi-publish@v1.9.0
99+
uses: pypa/gh-action-pypi-publish@release/v1
100100
with:
101101
repository-url: https://test.pypi.org/legacy/
102102

103103
- name: Publish to PyPI
104104
if: inputs.repository == 'pypi'
105-
uses: pypa/gh-action-pypi-publish@v1.9.0
105+
uses: pypa/gh-action-pypi-publish@release/v1

AGENTS.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ This repository is maintained as a careful, community-oriented Python client for
4444
- Prefer TestPyPI before first publishing under a new distribution name, but allow skipping it when CI, build metadata checks, and release-tag guards are sufficient.
4545
- Run the manual `Publish` workflow from a `v*` release tag only.
4646
- Keep the `testpypi` environment unblocked by manual review.
47-
- Keep the `pypi` environment protected by maintainer approval.
47+
- Do not require GitHub environment review for `pypi`; treat release PR merge,
48+
tag creation, and manual workflow dispatch as the publish approval path.
4849
- Trusted publishers must match project `printnode_community`, owner `cbusillo`, repository `printnode_community`, workflow `publish.yml`, and environment `testpypi` or `pypi`.
4950
- Update `CHANGELOG.md` for user-visible changes.
5051
- Keep release notes clear about whether this is an official PrintNode release or a community-maintained fork.

RELEASE.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ deactivate
6969
Configure two GitHub environments before publishing:
7070

7171
- `testpypi`: no required reviewer, so TestPyPI dry runs do not pause.
72-
- `pypi`: require maintainer approval before production publishing.
72+
- `pypi`: no GitHub environment reviewer. Production approval happens by
73+
merging the release PR, creating the release tag, and manually dispatching
74+
the publish workflow from that tag.
7375

7476
Configure each environment as a trusted publisher in the corresponding PyPI
7577
project before running the workflow. TestPyPI and PyPI are separate services;

0 commit comments

Comments
 (0)