updating the sdk breaks some tests (#147)

* updating the sdk breaks some tests

* ugh why did this behavior change

Author: jamescyeh

go.mod

@@ -5,7 +5,7 @@ replace github.com/bitmovin/bitmovin-api-sdk-go => github.com/zsiec/bitmovin-api
 require (
 	github.com/NYTimes/gizmo v1.3.5
 	github.com/NYTimes/gziphandler v1.1.1
-	github.com/aws/aws-sdk-go-v2 v0.19.0
+	github.com/aws/aws-sdk-go-v2 v0.20.0
 	github.com/aws/aws-xray-sdk-go v1.0.0-rc.15
 	github.com/bitmovin/bitmovin-api-sdk-go v1.36.0-alpha.0
 	github.com/cbsinteractive/hybrik-sdk-go v0.0.0-20191031180025-00f04ed90532

go.sum

@@ -37,6 +37,8 @@ github.com/aws/aws-sdk-go v1.29.24 h1:KOnds/LwADMDBaALL4UB98ZR+TUR1A1mYmAYbdLixL
 github.com/aws/aws-sdk-go v1.29.24/go.mod h1:1KvfttTE3SPKMpo8g2c6jL3ZKfXtFvKscTgahTma5Xg=
 github.com/aws/aws-sdk-go-v2 v0.19.0 h1:jVKVeRBQah2OwqXRoy8bnWWgpo2sXk/bWf2J2tog+lk=
 github.com/aws/aws-sdk-go-v2 v0.19.0/go.mod h1:JWVYvqSMppoMJC0x5wdwiImzgXTI9FuZwxzkQq9wy+g=
+github.com/aws/aws-sdk-go-v2 v0.20.0 h1:/yefUjgMrda9PNFwWctBU63nL10CJMdBwkAmaQ4w4Hs=
+github.com/aws/aws-sdk-go-v2 v0.20.0/go.mod h1:2LhT7UgHOXK3UXONKI5OMgIyoQL6zTAw/jwIeX6yqzw=
 github.com/aws/aws-xray-sdk-go v0.9.4/go.mod h1:XtMKdBQfpVut+tJEwI7+dJFRxxRdxHDyVNp2tHXRq04=
 github.com/aws/aws-xray-sdk-go v1.0.0-rc.15 h1:7XzuhQu1cTMaeKnBzEKpMG/d/wH214AoC/UZBEhht1U=
 github.com/aws/aws-xray-sdk-go v1.0.0-rc.15/go.mod h1:tmxq1c+yeEbMh39OmRFuXOrse5ajRlMmDXJ6LrCVsIs=

provider/mediaconvert/factory_test.go

@@ -57,12 +57,13 @@ func Test_mediaconvertFactory(t *testing.T) {
 			wantRegion: "us-cfg-region-1",
 		},
 		{
-			name: "when a config does not specify aws credentials or region, credentials and region are loaded " +
+			name: "when a config does not specify aws credentials, region, or profile, credentials and region are loaded " +
 				"from the environment",
 			envVars: map[string]string{
 				"AWS_ACCESS_KEY_ID":     "env_access_key_id",
 				"AWS_SECRET_ACCESS_KEY": "env_secret_access_key",
 				"AWS_DEFAULT_REGION":    "us-north-1",
+				"AWS_PROFILE":           "",
 			},
 			cfg: cfgWithoutCredsAndRegion,
 			wantCreds: aws.Credentials{

provider/mediaconvert/fake_client_test.go

@@ -28,7 +28,7 @@ type testMediaConvertClient struct {
 func (c *testMediaConvertClient) CreatePresetRequest(input *mediaconvert.CreatePresetInput) mediaconvert.CreatePresetRequest {
 	c.createPresetCalledWith = input
 	return mediaconvert.CreatePresetRequest{
-		Request: &aws.Request{HTTPRequest: &http.Request{}, Data: &mediaconvert.CreatePresetOutput{
+		Request: &aws.Request{HTTPRequest: &http.Request{}, Retryer: aws.NoOpRetryer{}, Data: &mediaconvert.CreatePresetOutput{
 			Preset: &mediaconvert.Preset{
 				Name: input.Name,
 				Settings: &mediaconvert.PresetSettings{
@@ -44,6 +44,7 @@ func (c *testMediaConvertClient) CreatePresetRequest(input *mediaconvert.CreateP
 func (c *testMediaConvertClient) GetJobRequest(*mediaconvert.GetJobInput) mediaconvert.GetJobRequest {
 	return mediaconvert.GetJobRequest{Request: &aws.Request{
 		HTTPRequest: &http.Request{},
+		Retryer:     aws.NoOpRetryer{},
 		Data: &mediaconvert.GetJobOutput{
 			Job: &c.jobReturnedByGetJob,
 		},
@@ -54,14 +55,15 @@ func (c *testMediaConvertClient) ListJobsRequest(*mediaconvert.ListJobsInput) me
 	c.listJobsCalled = true
 	return mediaconvert.ListJobsRequest{Request: &aws.Request{
 		HTTPRequest: &http.Request{},
+		Retryer:     aws.NoOpRetryer{},
 		Data:        &mediaconvert.ListJobsOutput{},
 	}}
 }
 
 func (c *testMediaConvertClient) CreateJobRequest(input *mediaconvert.CreateJobInput) mediaconvert.CreateJobRequest {
 	c.createJobCalledWith = *input
 	return mediaconvert.CreateJobRequest{
-		Request: &aws.Request{HTTPRequest: &http.Request{}, Data: &mediaconvert.CreateJobOutput{
+		Request: &aws.Request{HTTPRequest: &http.Request{}, Retryer: aws.NoOpRetryer{}, Data: &mediaconvert.CreateJobOutput{
 			Job: &mediaconvert.Job{
 				Id: aws.String(c.jobIDReturnedByCreateJob),
 			},
@@ -73,14 +75,15 @@ func (c *testMediaConvertClient) CancelJobRequest(input *mediaconvert.CancelJobI
 	c.cancelJobCalledWith = *input.Id
 	return mediaconvert.CancelJobRequest{Request: &aws.Request{
 		HTTPRequest: &http.Request{},
+		Retryer:     aws.NoOpRetryer{},
 		Data:        &mediaconvert.CancelJobOutput{},
 	}}
 }
 
 func (c *testMediaConvertClient) GetPresetRequest(input *mediaconvert.GetPresetInput) mediaconvert.GetPresetRequest {
 	c.getPresetCalledWith = *input.Name
 	return mediaconvert.GetPresetRequest{
-		Request: &aws.Request{HTTPRequest: &http.Request{}, Data: &mediaconvert.GetPresetOutput{
+		Request: &aws.Request{HTTPRequest: &http.Request{}, Retryer: aws.NoOpRetryer{}, Data: &mediaconvert.GetPresetOutput{
 			Preset: &mediaconvert.Preset{
 				Name: input.Name,
 				Settings: &mediaconvert.PresetSettings{
@@ -97,6 +100,7 @@ func (c *testMediaConvertClient) DeletePresetRequest(input *mediaconvert.DeleteP
 	c.deletePresetCalledWith = *input.Name
 	return mediaconvert.DeletePresetRequest{Request: &aws.Request{
 		HTTPRequest: &http.Request{},
+		Retryer:     aws.NoOpRetryer{},
 		Data:        &mediaconvert.DeletePresetOutput{},
 	}}
 }