Fix of Single Location Deconvolution Core Management + Tests #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonkoehn
changed the title
|
These tests rightfully fail as there is a bug in deconvolving a single location with more than one core. |
gordonkoehn
commented
Dec 19, 2024
lollipop/cli/deconvolute.py
Outdated
Comment on lines
549
to
560
| # check if the number of cores is valid | ||
| if n_cores < 1: | ||
| logger.ERROR("The number of cores must be at least 1.") | ||
| sys.exit(1) | ||
| # check if there are more cores than locations | ||
| if n_cores > len(locations_list): | ||
| logger.warning( | ||
| "The number of cores is greater than the number of locations." | ||
| ) | ||
| # adjust the number of cores to the number of locations | ||
| n_cores = len(loc) | ||
| logger.warning(f"The number of cores has been adjusted to {n_cores}.") |
There was a problem hiding this comment.
This was the bug ! The correction of cores was only done if no_loc=TRUE no location was given, this if was just one tab to far intended.
gordonkoehn
changed the title
gordonkoehn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves this issue:
It fixes a bug related to running the deconvolution for a single location with more than one core.
I further introduce more coverage tests specifically for single-location usage of LolliPop.
And ensured that the implemented logging was shown if the deconvolution was run via
click cli. Formerly it was not, hence no proper error message was given out.