Make test provider functions static

Author: bwalkerl

cleaner/backup/tests/cleaner_test.php

@@ -27,7 +27,7 @@
 
 class cleaner_backup_test extends \advanced_testcase {
 
-    public function delete_provider() {
+    public static function delete_provider() {
         // Array of filename, deleted.
         return [
             ['myfile.txt', false],

cleaner/email/tests/cleaner_email_test.php

@@ -154,7 +154,7 @@ public function test_cleaner_email_suffix_ignore_pattern($input, $expected, $suf
      *
      * @return array
      */
-    public function provider_for_cleaner_email_suffix_ignore_pattern() {
+    public static function provider_for_cleaner_email_suffix_ignore_pattern() {
         return [
             ['[email protected]',     '[email protected]',     '.suffix',   'moodle.com'],
             ['[email protected]',       '[email protected]',       '.suffix',   'emailsuffix.com'],

cleaner/muc/tests/phpunit/events_test.php

@@ -37,7 +37,7 @@ protected function setUp() : void {
         $this->resetAfterTest(false);
     }
 
-    public function provider_for_test_events_have_the_correct_properties() {
+    public static function provider_for_test_events_have_the_correct_properties() {
         return [
             [muc_config_saved::class, 'c'],
             [muc_config_deleted::class, 'd'],
@@ -70,7 +70,7 @@ public function test_events_have_the_correct_properties($class, $crud) {
         self::assertSame($expected, $actual);
     }
 
-    public function provider_for_test_events_have_the_correct_description() {
+    public static function provider_for_test_events_have_the_correct_description() {
         return [
             [
                 muc_config_saved::class,

tests/unit/table_scrambler_test.php

@@ -37,10 +37,10 @@
  * @SuppressWarnings(public) Allow as many methods as needed.
  */
 class local_datacleaner_table_scrambler_test extends advanced_testcase {
-    public function provider_for_it_creates_sorted_temporary_tables() {
+    public static function provider_for_it_creates_sorted_temporary_tables() {
         return [
             'unrepeated' => [
-                $this->create_test_data_array(),
+                self::create_test_data_array(),
                 [
                     ['id' => '1', 'value' => 'Bill'],
                     ['id' => '2', 'value' => 'David'],
@@ -75,7 +75,7 @@ public function provider_for_it_creates_sorted_temporary_tables() {
         ];
     }
 
-    public function provider_for_it_scrambles_names() {
+    public static function provider_for_it_scrambles_names() {
         return [
             ['', [
                 ['id' => '1', 'first' => 'David', 'last' => 'Jones'],
@@ -96,7 +96,7 @@ public function provider_for_it_scrambles_names() {
         ];
     }
 
-    public function provider_for_the_next_prime_after() {
+    public static function provider_for_the_next_prime_after() {
         return [
             [0, 2],
             [1, 2],
@@ -105,7 +105,7 @@ public function provider_for_the_next_prime_after() {
         ];
     }
 
-    public function provider_for_the_prime_factors() {
+    public static function provider_for_the_prime_factors() {
         return [
             [2, 1, [2, 3]],
             [2, 3, [2, 3]],
@@ -216,7 +216,7 @@ private function create_test_data($data = null) {
         global $DB;
 
         if (is_null($data)) {
-            $data = $this->create_test_data_array();
+            $data = self::create_test_data_array();
         }
 
         // Create test table.
@@ -237,7 +237,7 @@ private function create_test_data($data = null) {
         return $table;
     }
 
-    private function create_test_data_array() {
+    private static function create_test_data_array() {
         return [
             ['first' => 'David', 'last' => 'Smith'],
             ['first' => 'Nicholas', 'last' => 'Hoobin'],