update legacy OpenAPI services crates #86
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* limit vmware to just latest API for dev * fix test * begin updating to azure_core 0.22 * use latest and wait for 0.23 * models check * gen * just mod util for now * more renames * gen * do not gen into_stream or into_future for RequestBuilder * typespec_macros::Model * remove transport & retry * get subscription_id from env var * add Cargo.lock --------- Co-authored-by: Cameron Taggart <cameron.tagg>
Decouples paging from model types by removing pageable support in core and stopping generation of Continuable implementations. Updates paging to extract continuation tokens directly from the response payload using the configured nextLink, improving robustness when the field is optional or absent in the model. Keeps IntoFuture generation disabled pending LRO alignment and fixes a headers() lifetime lint. Regenerates VMware management APIs and adjusts dependencies accordingly.
Improves ergonomics and readability by adopting idiomatic patterns (e.g., is_ok_and, assert!, delegating PartialOrd to Ord), simplifying option handling, and removing redundant returns and unused imports. Boxes the struct enum variant to reduce enum size and avoid potential recursion size issues. Streamlines glob iteration and error handling, and tidies output formatting and error conversions. Enhances maintainability while aligning with modern Rust and clippy recommendations.
Encapsulates pager token emission in a dedicated helper, simplifying struct tokenization and improving readability and reuse. Preserves behavior for pageable models while preparing for future pager customization; updates internal wiring and naming only.
cataggar
commented
Sep 7, 2025
| for cloud in clouds.value { | ||
| println!("{:?}", cloud.tracked_resource.resource.id); | ||
| let clouds_client = client.private_clouds_client(); | ||
| let mut cloud_pager = clouds_client.list_in_subscription(subscription_id).pager()?; |
Owner
Author
There was a problem hiding this comment.
This can probably just be clouds. This example can go back to just listing clouds. I was trying out other APIs.
|
Hi @cataggar. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updates the
legacybranch generated services crates that are generated from the OpenAPI specs to use themainbranch SDKs.