Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather sounds continue to play in game mode #105

Open
kaashan opened this issue Oct 27, 2018 · 3 comments
Open

Weather sounds continue to play in game mode #105

kaashan opened this issue Oct 27, 2018 · 3 comments
Labels

Comments

@kaashan
Copy link

kaashan commented Oct 27, 2018

Launch https://winningcolors.herokuapp.com/
Change weather to "rainy" or "snow" and we can hear the relevant audio.
Now, launch the game mode by clicking on "Play Game" icon.
Notice that the audio can still be heard. Is this expected? Looks like an issues to me.

@kaashan kaashan changed the title Weather sounds continue to play in game mode [good first issue] Weather sounds continue to play in game mode Oct 27, 2018
@kaashan kaashan changed the title [good first issue] Weather sounds continue to play in game mode Weather sounds continue to play in game mode Oct 27, 2018
@caseydierking
Copy link
Owner

Hi Kaashan. This is a good catch. This is an issue that should be fixed. The rainy or snow audio probably shouldn't carry over into the game mode.

@kaashan
Copy link
Author

kaashan commented Oct 29, 2018

Thanks to put those labels :)
Can I take this if not being looked at already?

@caseydierking
Copy link
Owner

absolutely!

kaashan pushed a commit to kaashan/wcss that referenced this issue Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants