Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't we use tanh instead of sigmoid with this implementation? #18

Open
ghost opened this issue Aug 24, 2018 · 0 comments
Open

Shouldn't we use tanh instead of sigmoid with this implementation? #18

ghost opened this issue Aug 24, 2018 · 0 comments

Comments

@ghost
Copy link

ghost commented Aug 24, 2018

pixel-rnn-tensorflow/ops.py

Line 315 in 1d98c28

lstm_matrix = tf.sigmoid(s_to_s + i_to_s)

I have found at L315 that we have used the sigmoid function either to calculate the new inputs g, is that possible? Shouldn't we use the tanh instead?

Thank you
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants