Python 3?

[bossanova808]

Now that Python 2 is officially dead....any chance you will update this for Python 3?

[caronc]

Similar to #72, i hear you loud and clear with your request. It really comes down to time and effort; this project has kind of died on me as i maintain it for free (as all my other projects). Apprise and it's accompanied API have been my main focus right now. That and this COVID-19 issue has me also working more for my actual job since it's not as intuitive to work from home. Not trying to make excuses; but basically I'm a one man army here crying poor 😉 .

I'd love some help if you're offering to do a PR or know someone who can help out a bit?

[bossanova808]

Completely fair enough. I'm no Python 3 guru but if I get time I will look at it...I have several Kodi addons to convert, so might get into the groove with it...

But I will also have a look at bazarr which might be a nice replacement system...if a lot heavier.

[jaredcat]

Think you should leave this issue open till python 3 support is added for others (like me) who are looking to ask this question

[caronc]

@jaredkotoff: no problem; will do

[henryjfry]

@caronc

Ive made a wrapper for Subliminal from the current versions of the various libraries, this is therefore python 3 compliant?

https://github.com/henryjfry/subliminal_wrapper

So this wouldnt be something to replace this repo but I suspect you could replace the whole Subliminal folder on yours and it might start working for python3?

I dont use nzb but i was struggling to get Subliminal to work as a python module to use within Kodi and your repo helped me to figure it out.

So right now entirely self contained you can call or otherwise lauch the "get_subs_file()" from within "sub_lim.py" and if you give it a cache directory (also source for temp files) a video path or url and specify if you want to output subs to the same folder or not it'll fetch the subtitles and return the file paths.

If you give it a video url it will automatically output subs to a temp folder within the cache directory.
And you can add your OpenSubtitles.Org and OpenSuptitles.Com username/password in the config.json file as well as tmdb api key which is used to provide additional information to the video_dict it creates.

It doesnt use the internal hash method as this only works for local files and for my purposes i wanted to fetch subtitles to use with web streams playing back on kodi and therefore a while back i had figured out the method to compute the opensubtitles hash from a streaming file.

But anyway it should hopefully help you to fix this with python 3 as its a fully working implementation to search and download subtitles as i dont know if anything will have changed over versions.

I also not i had to manually add to "[babelfish.language_converters]" to the subliminal entry_points.txt:
opensubtitles = subliminal.converters.opensubtitles:OpenSubtitlesConverter

As i think this is a dependancy in bablefish but changed in subliminal?

[caronc]

Hi, I'm not sure how salvageable this repository is; it's pretty old now. Thank you for sharing the success you had on your own implementation! 🙏 It's just to hear of your success!