feat(types)!: use Component
type for type definitions
#203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #201
Currently, the generated type definitions use
SvelteComponentTyped
withdeclare class ...
for icon type definitions.SvelteComponentTyped
was deprecated in Svelte 4 and will be removed in a future major Svelte release.declare class
is no longer valid in Svelte 5 since components are no longer classes.This PR implements the following:
SvelteComponentTyped
with the officially recommendedComponent
utility type exported by Svelte.Breaking Changes
Argument of type 'Component<CarbonIconProps, {}, string>' is not assignable to parameter of type 'ConstructorOfATypedSvelteComponent'.
CarbonIcon class
is removed.CarbonIconProps
type is preserved, but the underlying type has been reworked to properly extend SVG "rest props".Additional Notes
ComponentProps<typeof Icon>
does not work as expected in Svelte 4. This indicates the value in preserving the exportedCarbonIconProps
type.$$restProps
to forward props down to the underlyingsvg
element.