Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying image version by hash during one-click deploy does not work #127

Open
sneak opened this issue Feb 5, 2020 · 3 comments
Open

Comments

@sneak
Copy link
Contributor

sneak commented Feb 5, 2020

I'm trying to deploy Gitea. I don't like deploying by image tag because those can be silently updated by developers on Docker Hub, granting them remote execution on my machine under certain circumstances.

When deploying it via one-click apps, I am prompted for the gitea version to deploy. I entered sha256:223c31793c1b486c3339cffc95e307b2094410f2fc0b0410c9488db828fe6b27 instead of latest. This failed during build.

When deploying these via the docker CLI, one must do docker run image@sha256:hash instead of docker run image:tagname.

It seems to me that CapRover should detect when a specified version starts with a hash algorithm identifier (if even only recognizing the static string sha256 for now, as is displayed on the Docker Hub website) and deploying appropriately based on image hash (cryptographically immutable) instead of tagname (developer mutable).

@githubsaturn
Copy link
Collaborator

Moving this to one-click apps repo as it's perhaps only related to regex validations of the tags which is totally one-click app specific.

@githubsaturn githubsaturn transferred this issue from caprover/caprover Feb 8, 2020
@sneak

This comment was marked as off-topic.

@githubsaturn
Copy link
Collaborator

It does support that. You can try copy-pasting this:

{"schemaVersion":2,"imageName":"nginx@sha256:253ba3484dc13498c0a2ad9e236f144dcc8c74ec08a0bcead9b776fa8a29dffc"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants