Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify TestStructuredProfilerRowStatistics: Update null stats tests #866

Open
micdavis opened this issue Jun 13, 2023 · 2 comments
Open

Modify TestStructuredProfilerRowStatistics: Update null stats tests #866

micdavis opened this issue Jun 13, 2023 · 2 comments
Assignees
@JGSweets @taylorfturner @micdavis @ksneab7
Labels
contribution_day good_first_issue Label for a more simple / introductory issue New Feature A feature addition not currently in the library

Comments

@micdavis
Copy link
Contributor

micdavis commented Jun 13, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
The null stats tests in TestStructuredProfilerRowStatistics link
need to be updated to use the data that is created in setUpClass link. Currently they are using their own datasets

Describe the outcome you'd like:
The null stats tests should use the data initialized in the setUpClass class method, not their own data
@micdavis micdavis added the New Feature A feature addition not currently in the library label Jun 13, 2023
@taylorfturner
Copy link
Contributor

Its effectively just pointing to a single data source or is it putting all the various datasets in the setUpClass method to just have them all setup and initialized in the setUpClass (i.e. still have a plethora of datasets just not in the "test" function)? @JGSweets

@taylorfturner taylorfturner mentioned this issue Jun 28, 2023
Closed
@jacob-buehler
Copy link
Contributor

pr #898 closed on june 28

@taylorfturner taylorfturner added good_first_issue Label for a more simple / introductory issue contribution_day labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JGSweets JGSweets

@taylorfturner taylorfturner

@micdavis micdavis

@ksneab7 ksneab7

Labels
contribution_day good_first_issue Label for a more simple / introductory issue New Feature A feature addition not currently in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@JGSweets @taylorfturner @micdavis @jacob-buehler @ksneab7