Skip to content

Commit 632ae6c

Browse files
StevenMaudeCopilot
andcommitted
Update OutputDev virtual method signatures
For poppler 26.04.0. In poppler commit 05cff0459bbec6365aed65448b1a297dfbb98340 ("Object: use std::variant over union"), the OutputDev virtual methods beginString, drawString, and beginActualText were changed to accept const std::string & instead of const GooString *. Update the overrides in DumpAsTextDev to match the new signatures so that they correctly override the base class methods. Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
1 parent 509b1b8 commit 632ae6c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/DumpAsTextDev.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ class DumpAsTextDev : public OutputDev {
367367
return OutputDev::endStringOp(A);
368368
}
369369

370-
void beginString(GfxState *A, const GooString *B) {
370+
void beginString(GfxState *A, const std::string &B) {
371371
printf("beginString\n");
372372
return OutputDev::beginString(A, B);
373373
}
@@ -385,7 +385,7 @@ class DumpAsTextDev : public OutputDev {
385385
return OutputDev::drawChar(A, B, C, D, E, F, G, H, I, J, K);
386386
}
387387

388-
void drawString(GfxState *A, const GooString *B) {
388+
void drawString(GfxState *A, const std::string &B) {
389389
printf("drawString\n");
390390
return OutputDev::drawString(A, B);
391391
}
@@ -416,7 +416,7 @@ class DumpAsTextDev : public OutputDev {
416416
return OutputDev::incCharCount(A);
417417
}
418418

419-
void beginActualText(GfxState *A, const GooString *B) {
419+
void beginActualText(GfxState *A, const std::string &B) {
420420
printf("beginActualText\n");
421421
return OutputDev::beginActualText(A, B);
422422
}

0 commit comments

Comments
 (0)